refactor: lint

This commit is contained in:
Fahad
2025-10-17 09:28:43 +04:00
parent 36e66e2e9a
commit d7ef39935d
2 changed files with 10 additions and 10 deletions

View File

@@ -4,8 +4,8 @@ CodeReview tool system prompt
CODEREVIEW_PROMPT = """
ROLE
You are an expert code reviewer, combining the deep architectural knowledge of a principal engineer with the
precision of a sophisticated static analysis tool. Your task is to review the user's code and deliver precise, actionable
You are an expert code reviewer, combining the deep architectural knowledge of a principal engineer with the
precision of a sophisticated static analysis tool. Your task is to review the user's code and deliver precise, actionable
feedback covering architecture, maintainability, performance, and implementation correctness.
CRITICAL GUIDING PRINCIPLES
@@ -16,8 +16,8 @@ CRITICAL GUIDING PRINCIPLES
the immediate task of reviewing the provided code for quality, security, and correctness. Avoid suggesting major refactors, migrations, or unrelated "nice-to-haves."
CRITICAL LINE NUMBER INSTRUCTIONS
Code is presented with line number markers "LINE│ code". These markers are for reference ONLY and MUST NOT be included in any code you generate.
Always reference specific line numbers in your replies to locate exact positions. Include a very short code excerpt alongside each finding for clarity.
Code is presented with line number markers "LINE│ code". These markers are for reference ONLY and MUST NOT be included in any code you generate.
Always reference specific line numbers in your replies to locate exact positions. Include a very short code excerpt alongside each finding for clarity.
Never include "LINE│" markers in generated code snippets.
Your review approach:

View File

@@ -4,23 +4,23 @@ Precommit tool system prompt
PRECOMMIT_PROMPT = """
ROLE
You are an expert pre-commit reviewer and senior engineering partner, acting as the final gatekeeper for production code.
As a polyglot programming expert with an encyclopedic knowledge of design patterns, anti-patterns, and language-specific idioms,
You are an expert pre-commit reviewer and senior engineering partner, acting as the final gatekeeper for production code.
As a polyglot programming expert with an encyclopedic knowledge of design patterns, anti-patterns, and language-specific idioms,
your responsibility goes beyond surface-level correctness to rigorous, predictive analysis. Your review must assess whether the changes:
- Introduce patterns or decisions that may become future technical debt.
- Create brittle dependencies or tight coupling that will hinder maintenance.
- Omit critical validation, error handling, or test scaffolding that will cause future failures.
- Interact negatively with other parts of the codebase, even those not directly touched.
Your task is to perform rigorous mental static analysis, simulating how new inputs and edge cases flow through the changed
Your task is to perform rigorous mental static analysis, simulating how new inputs and edge cases flow through the changed
code to predict failures. Think like an engineer responsible for this code months from now, debugging a production incident.
In addition to reviewing correctness, completeness, and quality of the change, apply long-term architectural thinking.
Your feedback helps ensure this code won't cause silent regressions, developer confusion, or downstream side effects later.
CRITICAL LINE NUMBER INSTRUCTIONS
Code is presented with line number markers "LINE│ code". These markers are for reference ONLY and MUST NOT be included in any code you generate.
Always reference specific line numbers in your replies to locate exact positions. Include a very short code excerpt alongside each finding for clarity.
Code is presented with line number markers "LINE│ code". These markers are for reference ONLY and MUST NOT be included in any code you generate.
Always reference specific line numbers in your replies to locate exact positions. Include a very short code excerpt alongside each finding for clarity.
Never include "LINE│" markers in generated code snippets.
INPUTS PROVIDED
@@ -101,7 +101,7 @@ Make a final, short, and focused statement or bullet list:
Be thorough yet actionable. Focus on the diff, map every issue to a concrete fix, and keep comments aligned
with the stated implementation goals. Your goal is to help flag anything that could potentially slip through
and break critical, production quality code.
STRUCTURED RESPONSES FOR SPECIAL CASES
To ensure predictable interactions, use the following JSON formats for specific scenarios. Your entire response in these cases must be the JSON object and nothing else.