Fixed challenge expectation
This commit is contained in:
Fahad
2025-06-30 13:35:40 +04:00
parent 268df43858
commit a70dcbe4d1
3 changed files with 9 additions and 14 deletions

View File

@@ -602,12 +602,10 @@ async def handle_list_tools() -> list[Tool]:
# Log to activity file as well # Log to activity file as well
try: try:
mcp_activity_logger = logging.getLogger("mcp_activity") mcp_activity_logger = logging.getLogger("mcp_activity")
friendly_name = client_info.get('friendly_name', 'Claude') friendly_name = client_info.get("friendly_name", "Claude")
raw_name = client_info.get('name', 'Unknown') raw_name = client_info.get("name", "Unknown")
version = client_info.get('version', 'Unknown') version = client_info.get("version", "Unknown")
mcp_activity_logger.info( mcp_activity_logger.info(f"MCP_CLIENT_INFO: {friendly_name} (raw={raw_name} v{version})")
f"MCP_CLIENT_INFO: {friendly_name} (raw={raw_name} v{version})"
)
except Exception: except Exception:
pass pass
except Exception as e: except Exception as e:

View File

@@ -24,9 +24,9 @@ class TestChallengeTool:
def test_tool_metadata(self): def test_tool_metadata(self):
"""Test that tool metadata matches requirements""" """Test that tool metadata matches requirements"""
assert self.tool.get_name() == "challenge" assert self.tool.get_name() == "challenge"
assert "CRITICAL CHALLENGE PROMPT" in self.tool.get_description() assert "prevent reflexive agreement" in self.tool.get_description()
assert "critical examination" in self.tool.get_description() assert "think critically" in self.tool.get_description()
assert "default agreement" in self.tool.get_description() assert "thoughtful evaluation" in self.tool.get_description()
assert self.tool.get_default_temperature() == 0.2 # TEMPERATURE_ANALYTICAL assert self.tool.get_default_temperature() == 0.2 # TEMPERATURE_ANALYTICAL
def test_requires_model(self): def test_requires_model(self):
@@ -154,8 +154,8 @@ class TestChallengeTool:
assert "prompt" in fields assert "prompt" in fields
assert fields["prompt"]["type"] == "string" assert fields["prompt"]["type"] == "string"
assert "statement" in fields["prompt"]["description"] assert "message or statement" in fields["prompt"]["description"]
assert "critically evaluate" in fields["prompt"]["description"] assert "analyze critically" in fields["prompt"]["description"]
def test_required_fields_list(self): def test_required_fields_list(self):
"""Test required fields list""" """Test required fields list"""

View File

@@ -25,19 +25,16 @@ CLIENT_NAME_MAPPINGS = {
"claude-desktop": "Claude", "claude-desktop": "Claude",
"claude-code": "Claude", "claude-code": "Claude",
"anthropic": "Claude", "anthropic": "Claude",
# Gemini variants # Gemini variants
"gemini-cli-mcp-client": "Gemini", "gemini-cli-mcp-client": "Gemini",
"gemini-cli": "Gemini", "gemini-cli": "Gemini",
"gemini": "Gemini", "gemini": "Gemini",
"google": "Gemini", "google": "Gemini",
# Other known clients # Other known clients
"cursor": "Cursor", "cursor": "Cursor",
"vscode": "VS Code", "vscode": "VS Code",
"codeium": "Codeium", "codeium": "Codeium",
"copilot": "GitHub Copilot", "copilot": "GitHub Copilot",
# Generic MCP clients # Generic MCP clients
"mcp-client": "MCP Client", "mcp-client": "MCP Client",
"test-client": "Test Client", "test-client": "Test Client",