From a70dcbe4d1e5441d39a137fb589a4c0430850ed0 Mon Sep 17 00:00:00 2001
From: Fahad <fahad@2doapp.com>
Date: Mon, 30 Jun 2025 13:35:40 +0400
Subject: [PATCH] Lint Fixed challenge expectation

---
 server.py               | 10 ++++------
 tests/test_challenge.py | 10 +++++-----
 utils/client_info.py    |  3 ---
 3 files changed, 9 insertions(+), 14 deletions(-)

diff --git a/server.py b/server.py
index 3d6aa4a..1bec7aa 100644
--- a/server.py
+++ b/server.py
@@ -602,12 +602,10 @@ async def handle_list_tools() -> list[Tool]:
             # Log to activity file as well
             try:
                 mcp_activity_logger = logging.getLogger("mcp_activity")
-                friendly_name = client_info.get('friendly_name', 'Claude')
-                raw_name = client_info.get('name', 'Unknown')
-                version = client_info.get('version', 'Unknown')
-                mcp_activity_logger.info(
-                    f"MCP_CLIENT_INFO: {friendly_name} (raw={raw_name} v{version})"
-                )
+                friendly_name = client_info.get("friendly_name", "Claude")
+                raw_name = client_info.get("name", "Unknown")
+                version = client_info.get("version", "Unknown")
+                mcp_activity_logger.info(f"MCP_CLIENT_INFO: {friendly_name} (raw={raw_name} v{version})")
             except Exception:
                 pass
     except Exception as e:
diff --git a/tests/test_challenge.py b/tests/test_challenge.py
index 18d69f6..6d93ccf 100644
--- a/tests/test_challenge.py
+++ b/tests/test_challenge.py
@@ -24,9 +24,9 @@ class TestChallengeTool:
     def test_tool_metadata(self):
         """Test that tool metadata matches requirements"""
         assert self.tool.get_name() == "challenge"
-        assert "CRITICAL CHALLENGE PROMPT" in self.tool.get_description()
-        assert "critical examination" in self.tool.get_description()
-        assert "default agreement" in self.tool.get_description()
+        assert "prevent reflexive agreement" in self.tool.get_description()
+        assert "think critically" in self.tool.get_description()
+        assert "thoughtful evaluation" in self.tool.get_description()
         assert self.tool.get_default_temperature() == 0.2  # TEMPERATURE_ANALYTICAL
 
     def test_requires_model(self):
@@ -154,8 +154,8 @@ class TestChallengeTool:
 
         assert "prompt" in fields
         assert fields["prompt"]["type"] == "string"
-        assert "statement" in fields["prompt"]["description"]
-        assert "critically evaluate" in fields["prompt"]["description"]
+        assert "message or statement" in fields["prompt"]["description"]
+        assert "analyze critically" in fields["prompt"]["description"]
 
     def test_required_fields_list(self):
         """Test required fields list"""
diff --git a/utils/client_info.py b/utils/client_info.py
index b0d1035..e32b7f3 100644
--- a/utils/client_info.py
+++ b/utils/client_info.py
@@ -25,19 +25,16 @@ CLIENT_NAME_MAPPINGS = {
     "claude-desktop": "Claude",
     "claude-code": "Claude",
     "anthropic": "Claude",
-
     # Gemini variants
     "gemini-cli-mcp-client": "Gemini",
     "gemini-cli": "Gemini",
     "gemini": "Gemini",
     "google": "Gemini",
-
     # Other known clients
     "cursor": "Cursor",
     "vscode": "VS Code",
     "codeium": "Codeium",
     "copilot": "GitHub Copilot",
-
     # Generic MCP clients
     "mcp-client": "MCP Client",
     "test-client": "Test Client",