27add4d05d
## 🚀 Major Improvements ### Docker Environment Simplification - **BREAKING**: Simplified Docker configuration by auto-detecting sandbox from WORKSPACE_ROOT - Removed redundant MCP_PROJECT_ROOT requirement for Docker setups - Updated all Docker config examples and setup scripts - Added security validation for dangerous WORKSPACE_ROOT paths ### Security Enhancements - **CRITICAL**: Fixed insecure PROJECT_ROOT fallback to use current directory instead of home - Enhanced path validation with proper Docker environment detection - Removed information disclosure in error messages - Strengthened symlink and path traversal protection ### File Handling Optimization - **PERFORMANCE**: Optimized read_files() to return content only (removed summary) - Unified file reading across all tools using standardized file_utils routines - Fixed review_changes tool to use consistent file loading patterns - Improved token management and reduced unnecessary processing ### Tool Improvements - **UX**: Enhanced ReviewCodeTool to require user context for targeted reviews - Removed deprecated _get_secure_container_path function and _sanitize_filename - Standardized file access patterns across analyze, review_changes, and other tools - Added contextual prompting to align reviews with user expectations ### Code Quality & Testing - Updated all tests for new function signatures and requirements - Added comprehensive Docker path integration tests - Achieved 100% test coverage (95 tests passing) - Full compliance with ruff, black, and isort linting standards ### Configuration & Deployment - Added pyproject.toml for modern Python packaging - Streamlined Docker setup removing redundant environment variables - Updated setup scripts across all platforms (Windows, macOS, Linux) - Improved error handling and validation throughout ## 🔧 Technical Changes - **Removed**: `_get_secure_container_path()`, `_sanitize_filename()`, unused SANDBOX_MODE - **Enhanced**: Path translation, security validation, token management - **Standardized**: File reading patterns, error handling, Docker detection - **Updated**: All tool prompts for better context alignment ## 🛡️ Security Notes This release significantly improves the security posture by: - Eliminating broad filesystem access defaults - Adding validation for Docker environment variables - Removing information disclosure in error paths - Strengthening path traversal and symlink protections 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
81 lines
2.6 KiB
Python
81 lines
2.6 KiB
Python
"""
|
|
Tests for the main server functionality
|
|
"""
|
|
|
|
from unittest.mock import Mock, patch
|
|
|
|
import pytest
|
|
|
|
from server import handle_call_tool, handle_list_tools
|
|
|
|
|
|
class TestServerTools:
|
|
"""Test server tool handling"""
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_handle_list_tools(self):
|
|
"""Test listing all available tools"""
|
|
tools = await handle_list_tools()
|
|
tool_names = [tool.name for tool in tools]
|
|
|
|
# Check all core tools are present
|
|
assert "think_deeper" in tool_names
|
|
assert "review_code" in tool_names
|
|
assert "debug_issue" in tool_names
|
|
assert "analyze" in tool_names
|
|
assert "chat" in tool_names
|
|
assert "review_changes" in tool_names
|
|
assert "get_version" in tool_names
|
|
|
|
# Should have exactly 7 tools
|
|
assert len(tools) == 7
|
|
|
|
# Check descriptions are verbose
|
|
for tool in tools:
|
|
assert len(tool.description) > 50 # All should have detailed descriptions
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_handle_call_tool_unknown(self):
|
|
"""Test calling an unknown tool"""
|
|
result = await handle_call_tool("unknown_tool", {})
|
|
assert len(result) == 1
|
|
assert "Unknown tool: unknown_tool" in result[0].text
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_handle_chat(self):
|
|
"""Test chat functionality"""
|
|
# Set test environment
|
|
import os
|
|
|
|
os.environ["PYTEST_CURRENT_TEST"] = "test"
|
|
|
|
# Create a mock for the model
|
|
with patch("tools.base.BaseTool.create_model") as mock_create:
|
|
mock_model = Mock()
|
|
mock_model.generate_content.return_value = Mock(
|
|
candidates=[Mock(content=Mock(parts=[Mock(text="Chat response")]))]
|
|
)
|
|
mock_create.return_value = mock_model
|
|
|
|
result = await handle_call_tool("chat", {"prompt": "Hello Gemini"})
|
|
|
|
assert len(result) == 1
|
|
# Parse JSON response
|
|
import json
|
|
|
|
response_data = json.loads(result[0].text)
|
|
assert response_data["status"] == "success"
|
|
assert "Chat response" in response_data["content"]
|
|
assert "Claude's Turn" in response_data["content"]
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_handle_get_version(self):
|
|
"""Test getting version info"""
|
|
result = await handle_call_tool("get_version", {})
|
|
assert len(result) == 1
|
|
|
|
response = result[0].text
|
|
assert "Gemini MCP Server v" in response # Version agnostic check
|
|
assert "Available Tools:" in response
|
|
assert "think_deeper" in response
|