From f55f2b0a0f0e479571eda6cade36a8742d1f2b19 Mon Sep 17 00:00:00 2001 From: Ming Date: Mon, 16 Jun 2025 23:12:16 +0800 Subject: [PATCH] Fix Google model restriction parameter order regression (#62) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit - Fixed swapped parameters in restriction_service.is_allowed() calls - Parameter order should be (provider_type, model_name, original_name) - Regression introduced in merge commit 39c50a1, breaking Gemini model access - Added comments to prevent future parameter order confusion - Resolves Gemini model is not allowed by restriction policy errors 🤖 Generated with Claude Code Co-authored-by: Ming Co-authored-by: Claude --- providers/gemini.py | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/providers/gemini.py b/providers/gemini.py index b7c9a41..8aec123 100644 --- a/providers/gemini.py +++ b/providers/gemini.py @@ -73,7 +73,9 @@ class GeminiModelProvider(ModelProvider): from utils.model_restrictions import get_restriction_service restriction_service = get_restriction_service() - if not restriction_service.is_allowed(ProviderType.GOOGLE, model_name, resolved_name): + # IMPORTANT: Parameter order is (provider_type, model_name, original_name) + # resolved_name is the canonical model name, model_name is the user input + if not restriction_service.is_allowed(ProviderType.GOOGLE, resolved_name, model_name): raise ValueError(f"Gemini model '{resolved_name}' is not allowed by restriction policy.") config = self.SUPPORTED_MODELS[resolved_name] @@ -255,7 +257,9 @@ class GeminiModelProvider(ModelProvider): from utils.model_restrictions import get_restriction_service restriction_service = get_restriction_service() - if not restriction_service.is_allowed(ProviderType.GOOGLE, model_name, resolved_name): + # IMPORTANT: Parameter order is (provider_type, model_name, original_name) + # resolved_name is the canonical model name, model_name is the user input + if not restriction_service.is_allowed(ProviderType.GOOGLE, resolved_name, model_name): logger.debug(f"Gemini model '{model_name}' -> '{resolved_name}' blocked by restrictions") return False