fix: address PR review feedback on test quality

- Remove broken test with unused mock parameter
- Replace placeholder test with actual validation of diagnostic messages
- Remove unused imports (MagicMock, patch)
- Fix whitespace and formatting issues
- Ensure all 6 tests pass with meaningful assertions

Addresses high-priority feedback from PR review comments.

tests/test_pip_detection_fix.py

@@ -7,7 +7,6 @@ and don't break existing functionality.
 import subprocess
 import tempfile
 from pathlib import Path
-from unittest.mock import MagicMock, patch
 
 import pytest
 
@@ -78,60 +77,27 @@ class TestPipDetectionFix:
             assert python_exe.is_file(), "Python should be a file"
             assert pip_exe.is_file(), "Pip should be a file"
 
-    @patch("subprocess.run")
+    def test_enhanced_diagnostic_messages_included(self):
-    def test_improved_pip_detection_logic(self, mock_run):
+        """Test that our enhanced diagnostic messages are included in the script.
-        """Test the improved pip detection logic we plan to implement.
 
-        Our fix should:
+        Verify that the script contains the enhanced error diagnostics we added.
-        1. Use consistent Python executable paths
-        2. Try multiple detection methods
-        3. Provide better error diagnostics
         """
-        # Mock successful pip detection
+        content = Path("./run-server.sh").read_text()
-        mock_run.return_value = MagicMock()
-        mock_run.return_value.returncode = 0
-        mock_run.return_value.stdout = "pip 23.0.1"
 
-        # Test that improved detection works with various scenarios
+        # Check that enhanced diagnostic information is present in the script
-        test_cases = [
+        expected_diagnostic_patterns = [
-            # (python_path, expected_success, description)
+            "Enhanced diagnostic information for debugging",
-            (".zen_venv/bin/python", True, "Relative path should work"),
+            "Diagnostic information:",
-            ("/full/path/.zen_venv/bin/python", True, "Absolute path should work"),
-            ("/usr/bin/python3", True, "System python should work if pip available"),
-        ]
-
-        for python_path, expected_success, _description in test_cases:
-            # This test defines what our fix should achieve
-            # The actual implementation will make these pass
-            subprocess.run([python_path, "-m", "pip", "--version"], capture_output=True)
-
-            if expected_success:
-                # After our fix, all these should succeed
-                pass  # Will be uncommented after fix implementation
-                # assert result.returncode == 0, f"Failed: {description}"
-
-    def test_pip_detection_error_diagnostics(self):
-        """Test that our fix provides better error diagnostics.
-
-        When pip detection fails, users should get helpful information
-        to debug the issue instead of generic error messages.
-        """
-        # This test defines what improved error messages should look like
-        expected_diagnostic_info = [
             "Python executable:",
             "Python executable exists:",
             "Python executable permissions:",
             "Virtual environment path:",
             "Virtual environment exists:",
-            "pip module:",
+            "Final diagnostic information:",
         ]
 
-        # After our fix, error messages should include these diagnostic details
+        for pattern in expected_diagnostic_patterns:
-        # This helps users understand what went wrong
+            assert pattern in content, f"Enhanced diagnostic pattern '{pattern}' should be in script"
-        for _info in expected_diagnostic_info:
-            # Test will verify our improved error handling includes this info
-            assert True  # Placeholder for actual diagnostic testing
-
 
 
 if __name__ == "__main__":