torbjorn/my-pal-mcp-server
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

refactor: removed method from provider, should use model capabilities instead

Browse Source 
refactor: cleanup temperature factory method
This commit is contained in:
Fahad
2025-10-02 11:08:56 +04:00
parent 9c11ecc4bf
commit a254ff2220
25 changed files with 105 additions and 224 deletions
Download Patch File Download Diff File Expand all files Collapse all files

44
tests/test_openai_provider.py
View File

@@ -252,33 +252,31 @@ class TestOpenAIProvider:
call_kwargs = mock_client.chat.completions.create.call_args[1]
assert call_kwargs["model"] == "o3-mini" # Should be unchanged
def test_supports_thinking_mode(self):
"""Test thinking mode support based on model capabilities."""
def test_extended_thinking_capabilities(self):
"""Thinking-mode support should be reflected via ModelCapabilities."""
provider = OpenAIModelProvider("test-key")
# GPT-5 models support thinking mode (reasoning tokens) - all variants
assert provider.supports_thinking_mode("gpt-5") is True
assert provider.supports_thinking_mode("gpt-5-mini") is True
assert provider.supports_thinking_mode("gpt-5-nano") is True # Now included
supported_aliases = [
"gpt-5",
"gpt-5-mini",
"gpt-5-nano",
"gpt5",
"gpt5-mini",
"gpt5mini",
"gpt5-nano",
"gpt5nano",
"nano",
"mini", # resolves to gpt-5-mini
]
for alias in supported_aliases:
assert provider.get_capabilities(alias).supports_extended_thinking is True
# Test GPT-5 aliases
assert provider.supports_thinking_mode("gpt5") is True
assert provider.supports_thinking_mode("gpt5-mini") is True
assert provider.supports_thinking_mode("gpt5mini") is True
assert provider.supports_thinking_mode("gpt5-nano") is True
assert provider.supports_thinking_mode("gpt5nano") is True
assert provider.supports_thinking_mode("nano") is True # New alias for gpt-5-nano
unsupported_aliases = ["o3", "o3-mini", "o4-mini"]
for alias in unsupported_aliases:
assert provider.get_capabilities(alias).supports_extended_thinking is False
# O3/O4 models don't support thinking mode
assert provider.supports_thinking_mode("o3") is False
assert provider.supports_thinking_mode("o3-mini") is False
assert provider.supports_thinking_mode("o4-mini") is False
assert (
provider.supports_thinking_mode("mini") is True
) # "mini" now resolves to gpt-5-mini which supports thinking
# Test invalid model name
assert provider.supports_thinking_mode("invalid-model") is False
# Invalid models should not validate, treat as unsupported
assert not provider.validate_model_name("invalid-model")
@patch("providers.openai_compatible.OpenAI")
def test_o3_pro_routes_to_responses_endpoint(self, mock_openai_class):