torbjorn/my-pal-mcp-server
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: improved error reporting; codex cli would at times fail to figure out how to handle plain-text / JSON errors

Browse Source 
fix: working directory should exist, raise error and not try and create one
docs: improved API Lookup instructions
* test added to confirm failures
* chat schema more explicit about file paths
This commit is contained in:
Fahad
2025-10-17 23:42:32 +04:00
parent 71796c0c70
commit 95e69a7cb2
24 changed files with 569 additions and 337 deletions
Download Patch File Download Diff File Expand all files Collapse all files

100
tests/test_thinking_modes.py
View File

@@ -87,16 +87,26 @@ class TestThinkingModes:
except Exception as e:
# Expected: API call will fail with fake key, but we can check the error
# If we get a provider resolution error, that's what we're testing
error_msg = str(e)
error_msg = getattr(e, "payload", str(e))
# Should NOT be a mock-related error - should be a real API or key error
assert "MagicMock" not in error_msg
assert "'<' not supported between instances" not in error_msg
# Should be a real provider error (API key, network, etc.)
assert any(
phrase in error_msg
for phrase in ["API", "key", "authentication", "provider", "network", "connection"]
)
import json
try:
parsed = json.loads(error_msg)
except Exception:
parsed = None
if isinstance(parsed, dict) and parsed.get("status", "").endswith("_failed"):
assert "validation errors" in parsed.get("error", "")
else:
assert any(
phrase in error_msg
for phrase in ["API", "key", "authentication", "provider", "network", "connection", "Model"]
)
finally:
# Restore environment
@@ -156,16 +166,26 @@ class TestThinkingModes:
except Exception as e:
# Expected: API call will fail with fake key
error_msg = str(e)
error_msg = getattr(e, "payload", str(e))
# Should NOT be a mock-related error
assert "MagicMock" not in error_msg
assert "'<' not supported between instances" not in error_msg
# Should be a real provider error
assert any(
phrase in error_msg
for phrase in ["API", "key", "authentication", "provider", "network", "connection"]
)
import json
try:
parsed = json.loads(error_msg)
except Exception:
parsed = None
if isinstance(parsed, dict) and parsed.get("status", "").endswith("_failed"):
assert "validation errors" in parsed.get("error", "")
else:
assert any(
phrase in error_msg
for phrase in ["API", "key", "authentication", "provider", "network", "connection", "Model"]
)
finally:
# Restore environment
@@ -226,16 +246,26 @@ class TestThinkingModes:
except Exception as e:
# Expected: API call will fail with fake key
error_msg = str(e)
error_msg = getattr(e, "payload", str(e))
# Should NOT be a mock-related error
assert "MagicMock" not in error_msg
assert "'<' not supported between instances" not in error_msg
# Should be a real provider error
assert any(
phrase in error_msg
for phrase in ["API", "key", "authentication", "provider", "network", "connection"]
)
import json
try:
parsed = json.loads(error_msg)
except Exception:
parsed = None
if isinstance(parsed, dict) and parsed.get("status", "").endswith("_failed"):
assert "validation errors" in parsed.get("error", "")
else:
assert any(
phrase in error_msg
for phrase in ["API", "key", "authentication", "provider", "network", "connection", "Model"]
)
finally:
# Restore environment
@@ -295,16 +325,26 @@ class TestThinkingModes:
except Exception as e:
# Expected: API call will fail with fake key
error_msg = str(e)
error_msg = getattr(e, "payload", str(e))
# Should NOT be a mock-related error
assert "MagicMock" not in error_msg
assert "'<' not supported between instances" not in error_msg
# Should be a real provider error
assert any(
phrase in error_msg
for phrase in ["API", "key", "authentication", "provider", "network", "connection"]
)
import json
try:
parsed = json.loads(error_msg)
except Exception:
parsed = None
if isinstance(parsed, dict) and parsed.get("status", "").endswith("_failed"):
assert "validation errors" in parsed.get("error", "")
else:
assert any(
phrase in error_msg
for phrase in ["API", "key", "authentication", "provider", "network", "connection", "Model"]
)
finally:
# Restore environment
@@ -367,16 +407,26 @@ class TestThinkingModes:
except Exception as e:
# Expected: API call will fail with fake key
error_msg = str(e)
error_msg = getattr(e, "payload", str(e))
# Should NOT be a mock-related error
assert "MagicMock" not in error_msg
assert "'<' not supported between instances" not in error_msg
# Should be a real provider error
assert any(
phrase in error_msg
for phrase in ["API", "key", "authentication", "provider", "network", "connection"]
)
import json
try:
parsed = json.loads(error_msg)
except Exception:
parsed = None
if isinstance(parsed, dict) and parsed.get("status", "").endswith("_failed"):
assert "validation errors" in parsed.get("error", "")
else:
assert any(
phrase in error_msg
for phrase in ["API", "key", "authentication", "provider", "network", "connection", "Model"]
)
finally:
# Restore environment