From 840b3deee480397661fc852f4e7f8ab4ea8052af Mon Sep 17 00:00:00 2001 From: Josh Vera Date: Sat, 12 Jul 2025 19:28:43 -0600 Subject: [PATCH] chore: Remove simplified PR template from version control MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Accidentally added it back with git add . 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude --- pr_template_filled_simplified.md | 59 -------------------------------- 1 file changed, 59 deletions(-) delete mode 100644 pr_template_filled_simplified.md diff --git a/pr_template_filled_simplified.md b/pr_template_filled_simplified.md deleted file mode 100644 index 3a8d7db..0000000 --- a/pr_template_filled_simplified.md +++ /dev/null @@ -1,59 +0,0 @@ -## PR Title - -**fix: Fix o3-pro empty response issue by using output_text field** - -## Summary - -Fixes o3-pro API calls returning empty responses due to incorrect response parsing. The code was trying to parse `response.output.content[]` array, but o3-pro provides `output_text` directly. - -## Changes - -- Fixed o3-pro response parsing to use `output_text` field -- Added `_safe_extract_output_text` method with validation -- Implemented HTTP transport recorder for testing expensive API calls -- Added PII sanitization for test recordings -- Added regression tests - -**No breaking changes** - Internal fix only - -## Testing - -```bash -source venv/bin/activate -./code_quality_checks.sh - -# Run the new tests added in this PR -python -m pytest tests/test_o3_pro_output_text_fix.py -v -python -m pytest tests/test_pii_sanitizer.py -v - -# Or run all new tests together -python -m pytest tests/test_o3_pro_output_text_fix.py tests/test_pii_sanitizer.py -v -``` - -- [x] All checks pass -- [x] Regression tests added: - - `test_o3_pro_output_text_fix.py` - Validates o3-pro response parsing and HTTP transport recording - - `test_pii_sanitizer.py` - Ensures API key sanitization - -## Code Example - -**Before:** -```python -# Incorrect - manual parsing -for content_item in response.output.content: - if content_item.type == "output_text": - content = content_item.text -``` - -**After:** -```python -# Correct - direct field access -content = response.output_text -``` - -## For Reviewers - -- Core fix: `providers/openai_compatible.py` - see `_safe_extract_output_text()` method -- Response parsing: `_generate_with_responses_endpoint()` method now uses the direct field -- Test infrastructure changes don't affect production code -- All test recordings sanitized for security \ No newline at end of file