From 6bd9d6709acfb584ab30a0a4d6891cabdb6d3ccf Mon Sep 17 00:00:00 2001
From: Sven Lito <me@svenlito.com>
Date: Sat, 23 Aug 2025 18:50:49 +0700
Subject: [PATCH] fix: address test failures and PR feedback

- Fix ModelContext constructor call in consensus tool (remove invalid parameters)
- Refactor temperature pattern matching for better readability per code review
- All tests now passing (799/799 passed)
---
 providers/custom.py | 19 ++++++++++---------
 tools/consensus.py  |  6 +-----
 2 files changed, 11 insertions(+), 14 deletions(-)

diff --git a/providers/custom.py b/providers/custom.py
index 9373909..64c5d68 100644
--- a/providers/custom.py
+++ b/providers/custom.py
@@ -210,15 +210,16 @@ class CustomProvider(OpenAICompatibleProvider):
 
         # Check for specific model patterns that don't support temperature
         for pattern in _TEMP_UNSUPPORTED_PATTERNS:
-            if (
-                pattern == model_lower
-                or model_lower.startswith(f"{pattern}-")
-                or model_lower.startswith(f"openai/{pattern}")
-                or model_lower.startswith(f"deepseek/{pattern}")
-                or model_lower.endswith(f"-{pattern}")
-                or f"/{pattern}" in model_lower
-                or f"-{pattern}-" in model_lower
-            ):
+            conditions = (
+                pattern == model_lower,
+                model_lower.startswith(f"{pattern}-"),
+                model_lower.startswith(f"openai/{pattern}"),
+                model_lower.startswith(f"deepseek/{pattern}"),
+                model_lower.endswith(f"-{pattern}"),
+                f"/{pattern}" in model_lower,
+                f"-{pattern}-" in model_lower,
+            )
+            if any(conditions):
                 return False, f"detected non-temperature-supporting model pattern '{pattern}'"
 
         # Check for specific keywords that indicate non-supporting variants
diff --git a/tools/consensus.py b/tools/consensus.py
index 7e5d169..cc88697 100644
--- a/tools/consensus.py
+++ b/tools/consensus.py
@@ -548,11 +548,7 @@ of the evidence, even when it strongly points in one direction.""",
             system_prompt = self._get_stance_enhanced_prompt(stance, stance_prompt)
 
             # Get model context for temperature validation
-            model_context = ModelContext(
-                model_name=model_name,
-                provider=provider.get_provider_type(),
-                provider_instance=provider,
-            )
+            model_context = ModelContext(model_name=model_name)
 
             # Validate temperature against model constraints (respects supports_temperature)
             validated_temperature, temp_warnings = self.validate_and_correct_temperature(