From 61911e6be7a9ebb1c79879faf291b9ee2841e39e Mon Sep 17 00:00:00 2001 From: Patryk Ciechanski Date: Thu, 12 Jun 2025 11:51:45 +0200 Subject: [PATCH] fix: GitHub Actions workflows semantic errors MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Fixed critical semantic and logic errors in auto-version and Docker workflows: Auto-version.yml fixes: - Removed duplicate echo statements for should_build_docker output - Fixed malformed if/else structure (else after else) - Removed redundant conditional blocks for docker: prefixes - Cleaned up duplicate lines in summary generation Build_and_publish_docker.yml fixes: - Replaced hardcoded 'patrykiti' with dynamic ${{ github.repository_owner }} - Enhanced regex pattern to support underscores in Docker tags: [a-zA-Z0-9\._-]* - Fixed sed patterns for dynamic repository owner detection These changes ensure workflows execute correctly and support any repository owner. 🤖 Generated with Claude Code Co-Authored-By: Claude --- .github/workflows/auto-version.yml | 24 ------------------- .../workflows/build_and_publish_docker.yml | 6 ++--- 2 files changed, 3 insertions(+), 27 deletions(-) diff --git a/.github/workflows/auto-version.yml b/.github/workflows/auto-version.yml index 0779a07..9149f55 100644 --- a/.github/workflows/auto-version.yml +++ b/.github/workflows/auto-version.yml @@ -46,13 +46,11 @@ jobs: echo "bump_type=major" >> $GITHUB_OUTPUT echo "should_bump=true" >> $GITHUB_OUTPUT echo "should_build_docker=true" >> $GITHUB_OUTPUT - echo "should_build_docker=true" >> $GITHUB_OUTPUT elif [[ "$PR_TITLE_LOWER" =~ ^feat: ]]; then echo "Detected new feature - minor version bump" echo "bump_type=minor" >> $GITHUB_OUTPUT echo "should_bump=true" >> $GITHUB_OUTPUT echo "should_build_docker=true" >> $GITHUB_OUTPUT - echo "should_build_docker=true" >> $GITHUB_OUTPUT elif [[ "$PR_TITLE_LOWER" =~ ^(fix|perf|refactor): ]]; then echo "Detected fix/perf/refactor - patch version bump" echo "bump_type=patch" >> $GITHUB_OUTPUT @@ -63,17 +61,6 @@ jobs: echo "bump_type=none" >> $GITHUB_OUTPUT echo "should_bump=false" >> $GITHUB_OUTPUT echo "should_build_docker=true" >> $GITHUB_OUTPUT - elif [[ "$PR_TITLE_LOWER" =~ ^(docs|chore|test|ci|style)\+docker: ]]; then - echo "Detected non-versioned change with Docker build request" - echo "bump_type=none" >> $GITHUB_OUTPUT - echo "should_bump=false" >> $GITHUB_OUTPUT - echo "should_build_docker=true" >> $GITHUB_OUTPUT - echo "should_build_docker=true" >> $GITHUB_OUTPUT - elif [[ "$PR_TITLE_LOWER" =~ ^docker: ]]; then - echo "Detected docker build request - no version bump but build Docker" - echo "bump_type=none" >> $GITHUB_OUTPUT - echo "should_bump=false" >> $GITHUB_OUTPUT - echo "should_build_docker=true" >> $GITHUB_OUTPUT elif [[ "$PR_TITLE_LOWER" =~ ^(docs|chore|test|ci|style)\+docker: ]]; then echo "Detected non-versioned change with Docker build request" echo "bump_type=none" >> $GITHUB_OUTPUT @@ -84,14 +71,11 @@ jobs: echo "bump_type=none" >> $GITHUB_OUTPUT echo "should_bump=false" >> $GITHUB_OUTPUT echo "should_build_docker=false" >> $GITHUB_OUTPUT - else - echo "should_build_docker=false" >> $GITHUB_OUTPUT else echo "No recognized prefix - no version bump" echo "bump_type=none" >> $GITHUB_OUTPUT echo "should_bump=false" >> $GITHUB_OUTPUT echo "should_build_docker=false" >> $GITHUB_OUTPUT - echo "should_build_docker=false" >> $GITHUB_OUTPUT fi - name: Get current version @@ -247,14 +231,6 @@ jobs: echo "- **Tag**: v${{ steps.new_version.outputs.version }}" >> $GITHUB_STEP_SUMMARY echo "- **PR**: #${{ github.event.pull_request.number }}" >> $GITHUB_STEP_SUMMARY echo "- **Docker**: Will build and publish with new tag" >> $GITHUB_STEP_SUMMARY - elif [ "${{ steps.bump_type.outputs.should_build_docker }}" == "true" ]; then - echo "### 🐳 Docker Build Requested" >> $GITHUB_STEP_SUMMARY - echo "" >> $GITHUB_STEP_SUMMARY - echo "No version bump but Docker image will be built and published." >> $GITHUB_STEP_SUMMARY - echo "- **PR**: #${{ github.event.pull_request.number }}" >> $GITHUB_STEP_SUMMARY - echo "- **Title**: ${{ github.event.pull_request.title }}" >> $GITHUB_STEP_SUMMARY - echo "- **Docker tag**: Based on commit SHA" >> $GITHUB_STEP_SUMMARY - echo "- **Docker**: Will build and publish with new tag" >> $GITHUB_STEP_SUMMARY elif [ "${{ steps.bump_type.outputs.should_build_docker }}" == "true" ]; then echo "### 🐳 Docker Build Requested" >> $GITHUB_STEP_SUMMARY echo "" >> $GITHUB_STEP_SUMMARY diff --git a/.github/workflows/build_and_publish_docker.yml b/.github/workflows/build_and_publish_docker.yml index e5bbf31..1ebe230 100644 --- a/.github/workflows/build_and_publish_docker.yml +++ b/.github/workflows/build_and_publish_docker.yml @@ -132,13 +132,13 @@ jobs: echo "Updating README.md with latest Docker image: $LATEST_TAG" # Update README.md with the latest image tag - sed -i.bak "s|ghcr\.io/patrykiti/gemini-mcp-server:[a-zA-Z0-9\.-]*|$LATEST_TAG|g" README.md + sed -i.bak "s|ghcr\.io/${{ github.repository_owner }}/gemini-mcp-server:[a-zA-Z0-9\._-]*|$LATEST_TAG|g" README.md # Also update docs/user-guides/installation.md - sed -i.bak "s|ghcr\.io/patrykiti/gemini-mcp-server:[a-zA-Z0-9\.-]*|$LATEST_TAG|g" docs/user-guides/installation.md + sed -i.bak "s|ghcr\.io/${{ github.repository_owner }}/gemini-mcp-server:[a-zA-Z0-9\._-]*|$LATEST_TAG|g" docs/user-guides/installation.md # Also update docs/user-guides/configuration.md - sed -i.bak "s|ghcr\.io/patrykiti/gemini-mcp-server:[a-zA-Z0-9\.-]*|$LATEST_TAG|g" docs/user-guides/configuration.md + sed -i.bak "s|ghcr\.io/${{ github.repository_owner }}/gemini-mcp-server:[a-zA-Z0-9\._-]*|$LATEST_TAG|g" docs/user-guides/configuration.md # Check if there are any changes if git diff --quiet README.md docs/user-guides/installation.md docs/user-guides/configuration.md; then