Merge branch 'main' into feat-dockerisation
This commit is contained in:
@@ -153,6 +153,13 @@ LOG_LEVEL=DEBUG
|
|||||||
# DISABLED_TOOLS=debug,tracer # Disable debug and tracer tools
|
# DISABLED_TOOLS=debug,tracer # Disable debug and tracer tools
|
||||||
# DISABLED_TOOLS=planner,consensus # Disable planning tools
|
# DISABLED_TOOLS=planner,consensus # Disable planning tools
|
||||||
|
|
||||||
|
# Optional: Language/Locale for AI responses
|
||||||
|
# When set, all AI tools will respond in the specified language
|
||||||
|
# while maintaining their analytical capabilities
|
||||||
|
# Examples: "fr-FR", "en-US", "zh-CN", "zh-TW", "ja-JP", "ko-KR", "es-ES"
|
||||||
|
# Leave empty for default language (English)
|
||||||
|
# LOCALE=fr-FR
|
||||||
|
|
||||||
# ===========================================
|
# ===========================================
|
||||||
# Docker Configuration
|
# Docker Configuration
|
||||||
# ===========================================
|
# ===========================================
|
||||||
|
|||||||
@@ -136,6 +136,15 @@ def _calculate_mcp_prompt_limit() -> int:
|
|||||||
|
|
||||||
MCP_PROMPT_SIZE_LIMIT = _calculate_mcp_prompt_limit()
|
MCP_PROMPT_SIZE_LIMIT = _calculate_mcp_prompt_limit()
|
||||||
|
|
||||||
|
# Language/Locale Configuration
|
||||||
|
# LOCALE: Language/locale specification for AI responses
|
||||||
|
# When set, all AI tools will respond in the specified language while
|
||||||
|
# maintaining their analytical capabilities
|
||||||
|
# Examples: "fr-FR", "en-US", "zh-CN", "zh-TW", "ja-JP", "ko-KR", "es-ES",
|
||||||
|
# "de-DE", "it-IT", "pt-PT"
|
||||||
|
# Leave empty for default language (English)
|
||||||
|
LOCALE = os.getenv("LOCALE", "")
|
||||||
|
|
||||||
# Threading configuration
|
# Threading configuration
|
||||||
# Simple in-memory conversation threading for stateless MCP environment
|
# Simple in-memory conversation threading for stateless MCP environment
|
||||||
# Conversations persist only during the Claude session
|
# Conversations persist only during the Claude session
|
||||||
|
|||||||
186
docs/locale-configuration.md
Normal file
186
docs/locale-configuration.md
Normal file
@@ -0,0 +1,186 @@
|
|||||||
|
# Locale Configuration for Zen MCP Server
|
||||||
|
|
||||||
|
This guide explains how to configure and use the localization feature to customize the language of responses from MCP tools.
|
||||||
|
|
||||||
|
## Overview
|
||||||
|
|
||||||
|
The localization feature allows you to specify the language in which MCP tools should respond, while maintaining their analytical capabilities. This is especially useful for non-English speakers who want to receive answers in their native language.
|
||||||
|
|
||||||
|
## Configuration
|
||||||
|
|
||||||
|
### 1. Environment Variable
|
||||||
|
|
||||||
|
Set the language using the `LOCALE` environment variable in your `.env` file:
|
||||||
|
|
||||||
|
```bash
|
||||||
|
# In your .env file
|
||||||
|
LOCALE=fr-FR
|
||||||
|
```
|
||||||
|
|
||||||
|
### 2. Supported Languages
|
||||||
|
|
||||||
|
You can use any standard language code. Examples:
|
||||||
|
|
||||||
|
- `fr-FR` - French (France)
|
||||||
|
- `en-US` - English (United States)
|
||||||
|
- `zh-CN` - Chinese (Simplified)
|
||||||
|
- `zh-TW` - Chinese (Traditional)
|
||||||
|
- `ja-JP` - Japanese
|
||||||
|
- `ko-KR` - Korean
|
||||||
|
- `es-ES` - Spanish (Spain)
|
||||||
|
- `de-DE` - German (Germany)
|
||||||
|
- `it-IT` - Italian (Italy)
|
||||||
|
- `pt-PT` - Portuguese (Portugal)
|
||||||
|
- `ru-RU` - Russian (Russia)
|
||||||
|
- `ar-SA` - Arabic (Saudi Arabia)
|
||||||
|
|
||||||
|
### 3. Default Behavior
|
||||||
|
|
||||||
|
If no language is specified (`LOCALE` is empty or unset), tools will default to English.
|
||||||
|
|
||||||
|
## Technical Implementation
|
||||||
|
|
||||||
|
### Architecture
|
||||||
|
|
||||||
|
Localization is implemented in the `BaseTool` class in `tools/shared/base_tool.py`. All tools inherit this feature automatically.
|
||||||
|
|
||||||
|
### `get_language_instruction()` Method
|
||||||
|
|
||||||
|
```python
|
||||||
|
def get_language_instruction(self) -> str:
|
||||||
|
"""
|
||||||
|
Generate language instruction based on LOCALE configuration.
|
||||||
|
Returns:
|
||||||
|
str: Language instruction to prepend to prompt, or empty string if no locale set
|
||||||
|
"""
|
||||||
|
from config import LOCALE
|
||||||
|
if not LOCALE or not LOCALE.strip():
|
||||||
|
return ""
|
||||||
|
return f"Always respond in {LOCALE.strip()}.\n\n"
|
||||||
|
```
|
||||||
|
|
||||||
|
### Integration in Tool Execution
|
||||||
|
|
||||||
|
The language instruction is automatically prepended to the system prompt of each tool:
|
||||||
|
|
||||||
|
```python
|
||||||
|
# In tools/simple/base.py
|
||||||
|
base_system_prompt = self.get_system_prompt()
|
||||||
|
language_instruction = self.get_language_instruction()
|
||||||
|
system_prompt = language_instruction + base_system_prompt
|
||||||
|
```
|
||||||
|
|
||||||
|
## Usage
|
||||||
|
|
||||||
|
### 1. Basic Setup
|
||||||
|
|
||||||
|
1. Edit your `.env` file:
|
||||||
|
```bash
|
||||||
|
LOCALE=fr-FR
|
||||||
|
```
|
||||||
|
2. Restart the MCP server:
|
||||||
|
```bash
|
||||||
|
python server.py
|
||||||
|
```
|
||||||
|
3. Use any tool – responses will be in the specified language.
|
||||||
|
|
||||||
|
### 2. Example
|
||||||
|
|
||||||
|
**Before (default English):**
|
||||||
|
```
|
||||||
|
Tool: chat
|
||||||
|
Input: "Explain how to use Python dictionaries"
|
||||||
|
Output: "Python dictionaries are key-value pairs that allow you to store and organize data..."
|
||||||
|
```
|
||||||
|
|
||||||
|
**After (with LOCALE=fr-FR):**
|
||||||
|
```
|
||||||
|
Tool: chat
|
||||||
|
Input: "Explain how to use Python dictionaries"
|
||||||
|
Output: "Les dictionnaires Python sont des paires clé-valeur qui permettent de stocker et d'organiser des données..."
|
||||||
|
```
|
||||||
|
|
||||||
|
### 3. Affected Tools
|
||||||
|
|
||||||
|
All MCP tools are affected by this configuration:
|
||||||
|
|
||||||
|
- `chat` – General conversation
|
||||||
|
- `codereview` – Code review
|
||||||
|
- `analyze` – Code analysis
|
||||||
|
- `debug` – Debugging
|
||||||
|
- `refactor` – Refactoring
|
||||||
|
- `thinkdeep` – Deep thinking
|
||||||
|
- `consensus` – Model consensus
|
||||||
|
- And all other tools...
|
||||||
|
|
||||||
|
## Best Practices
|
||||||
|
|
||||||
|
### 1. Language Choice
|
||||||
|
- Use standard language codes (ISO 639-1 with ISO 3166-1 country codes)
|
||||||
|
- Be specific with regional variants if needed (e.g., `zh-CN` vs `zh-TW`)
|
||||||
|
|
||||||
|
### 2. Consistency
|
||||||
|
- Use the same language setting across your team for consistency
|
||||||
|
- Document the chosen language in your team documentation
|
||||||
|
|
||||||
|
### 3. Testing
|
||||||
|
- Test the configuration with different tools to ensure consistency
|
||||||
|
|
||||||
|
## Troubleshooting
|
||||||
|
|
||||||
|
### Issue: Language does not change
|
||||||
|
**Solution:**
|
||||||
|
1. Check that the `LOCALE` variable is correctly set in `.env`
|
||||||
|
2. Fully restart the MCP server
|
||||||
|
3. Ensure there are no extra spaces in the value
|
||||||
|
|
||||||
|
### Issue: Partially translated responses
|
||||||
|
**Explanation:**
|
||||||
|
- AI models may sometimes mix languages
|
||||||
|
- This depends on the multilingual capabilities of the model used
|
||||||
|
- Technical terms may remain in English
|
||||||
|
|
||||||
|
### Issue: Configuration errors
|
||||||
|
**Solution:**
|
||||||
|
1. Check the syntax of your `.env` file
|
||||||
|
2. Make sure there are no quotes around the value
|
||||||
|
|
||||||
|
## Advanced Customization
|
||||||
|
|
||||||
|
### Customizing the Language Instruction
|
||||||
|
|
||||||
|
To customize the language instruction, modify the `get_language_instruction()` method in `tools/shared/base_tool.py`:
|
||||||
|
|
||||||
|
```python
|
||||||
|
def get_language_instruction(self) -> str:
|
||||||
|
from config import LOCALE
|
||||||
|
if not LOCALE or not LOCALE.strip():
|
||||||
|
return ""
|
||||||
|
# Custom instruction
|
||||||
|
return f"Always respond in {LOCALE.strip()} and use a professional tone.\n\n"
|
||||||
|
```
|
||||||
|
|
||||||
|
### Per-Tool Customization
|
||||||
|
|
||||||
|
You can also override the method in specific tools for custom behavior:
|
||||||
|
|
||||||
|
```python
|
||||||
|
class MyCustomTool(SimpleTool):
|
||||||
|
def get_language_instruction(self) -> str:
|
||||||
|
from config import LOCALE
|
||||||
|
if LOCALE == "fr-FR":
|
||||||
|
return "Respond in French with precise technical vocabulary.\n\n"
|
||||||
|
elif LOCALE == "zh-CN":
|
||||||
|
return "请用中文回答,使用专业术语。\n\n"
|
||||||
|
else:
|
||||||
|
return super().get_language_instruction()
|
||||||
|
```
|
||||||
|
|
||||||
|
## Integration with Other Features
|
||||||
|
|
||||||
|
Localization works with all other MCP server features:
|
||||||
|
|
||||||
|
- **Conversation threading** – Multilingual conversations are supported
|
||||||
|
- **File processing** – File analysis is in the specified language
|
||||||
|
- **Web search** – Search instructions remain functional
|
||||||
|
- **Model selection** – Works with all supported models
|
||||||
@@ -311,11 +311,12 @@ class OpenAICompatibleProvider(ModelProvider):
|
|||||||
last_exception = None
|
last_exception = None
|
||||||
|
|
||||||
for attempt in range(max_retries):
|
for attempt in range(max_retries):
|
||||||
try:
|
try: # Log the exact payload being sent for debugging
|
||||||
# Log the exact payload being sent for debugging
|
|
||||||
import json
|
import json
|
||||||
|
|
||||||
logging.info(f"o3-pro API request payload: {json.dumps(completion_params, indent=2)}")
|
logging.info(
|
||||||
|
f"o3-pro API request payload: {json.dumps(completion_params, indent=2, ensure_ascii=False)}"
|
||||||
|
)
|
||||||
|
|
||||||
# Use OpenAI client's responses endpoint
|
# Use OpenAI client's responses endpoint
|
||||||
response = self.client.responses.create(**completion_params)
|
response = self.client.responses.create(**completion_params)
|
||||||
|
|||||||
@@ -136,10 +136,12 @@ class Calculator:
|
|||||||
"id": 2,
|
"id": 2,
|
||||||
"method": "tools/call",
|
"method": "tools/call",
|
||||||
"params": {"name": tool_name, "arguments": params},
|
"params": {"name": tool_name, "arguments": params},
|
||||||
}
|
} # Combine all messages
|
||||||
|
messages = [
|
||||||
# Combine all messages
|
json.dumps(init_request, ensure_ascii=False),
|
||||||
messages = [json.dumps(init_request), json.dumps(initialized_notification), json.dumps(tool_request)]
|
json.dumps(initialized_notification, ensure_ascii=False),
|
||||||
|
json.dumps(tool_request, ensure_ascii=False),
|
||||||
|
]
|
||||||
|
|
||||||
# Join with newlines as MCP expects
|
# Join with newlines as MCP expects
|
||||||
input_data = "\n".join(messages) + "\n"
|
input_data = "\n".join(messages) + "\n"
|
||||||
|
|||||||
@@ -112,11 +112,9 @@ class UserService:
|
|||||||
result = await self.db.execute(
|
result = await self.db.execute(
|
||||||
"SELECT * FROM users WHERE id = %s", (user_id,)
|
"SELECT * FROM users WHERE id = %s", (user_id,)
|
||||||
)
|
)
|
||||||
user_data = result.fetchone()
|
user_data = result.fetchone() if user_data:
|
||||||
|
|
||||||
if user_data:
|
|
||||||
# Cache for 1 hour - magic number
|
# Cache for 1 hour - magic number
|
||||||
self.cache.setex(cache_key, 3600, json.dumps(user_data))
|
self.cache.setex(cache_key, 3600, json.dumps(user_data, ensure_ascii=False))
|
||||||
|
|
||||||
return user_data
|
return user_data
|
||||||
|
|
||||||
@@ -273,10 +271,8 @@ class UserProfile(Base):
|
|||||||
try:
|
try:
|
||||||
return json.loads(self.preferences) if self.preferences else {}
|
return json.loads(self.preferences) if self.preferences else {}
|
||||||
except json.JSONDecodeError:
|
except json.JSONDecodeError:
|
||||||
return {}
|
return {} def set_preferences(self, prefs: dict):
|
||||||
|
self.preferences = json.dumps(prefs, ensure_ascii=False)
|
||||||
def set_preferences(self, prefs: dict):
|
|
||||||
self.preferences = json.dumps(prefs)
|
|
||||||
|
|
||||||
class AuditLog(Base):
|
class AuditLog(Base):
|
||||||
__tablename__ = "audit_logs"
|
__tablename__ = "audit_logs"
|
||||||
@@ -298,7 +294,7 @@ class AuditLog(Base):
|
|||||||
log = cls(
|
log = cls(
|
||||||
user_id=user_id,
|
user_id=user_id,
|
||||||
action=action,
|
action=action,
|
||||||
details=json.dumps(details) if details else None,
|
details=json.dumps(details, ensure_ascii=False) if details else None,
|
||||||
ip_address=ip_address,
|
ip_address=ip_address,
|
||||||
user_agent=user_agent
|
user_agent=user_agent
|
||||||
)
|
)
|
||||||
@@ -692,9 +688,7 @@ class PerformanceTimer:
|
|||||||
|
|
||||||
if not response_final_data.get("analysis_complete"):
|
if not response_final_data.get("analysis_complete"):
|
||||||
self.logger.error("Expected analysis_complete=true for final step")
|
self.logger.error("Expected analysis_complete=true for final step")
|
||||||
return False
|
return False # Check for expert analysis
|
||||||
|
|
||||||
# Check for expert analysis
|
|
||||||
if "expert_analysis" not in response_final_data:
|
if "expert_analysis" not in response_final_data:
|
||||||
self.logger.error("Missing expert_analysis in final response")
|
self.logger.error("Missing expert_analysis in final response")
|
||||||
return False
|
return False
|
||||||
@@ -702,7 +696,7 @@ class PerformanceTimer:
|
|||||||
expert_analysis = response_final_data.get("expert_analysis", {})
|
expert_analysis = response_final_data.get("expert_analysis", {})
|
||||||
|
|
||||||
# Check for expected analysis content (checking common patterns)
|
# Check for expected analysis content (checking common patterns)
|
||||||
analysis_text = json.dumps(expert_analysis).lower()
|
analysis_text = json.dumps(expert_analysis, ensure_ascii=False).lower()
|
||||||
|
|
||||||
# Look for architectural analysis indicators
|
# Look for architectural analysis indicators
|
||||||
arch_indicators = ["architecture", "pattern", "coupling", "dependency", "scalability", "maintainability"]
|
arch_indicators = ["architecture", "pattern", "coupling", "dependency", "scalability", "maintainability"]
|
||||||
|
|||||||
@@ -514,7 +514,7 @@ class ConfigurationManager:
|
|||||||
expert_analysis = response_final_data.get("expert_analysis", {})
|
expert_analysis = response_final_data.get("expert_analysis", {})
|
||||||
|
|
||||||
# Check for expected analysis content (checking common patterns)
|
# Check for expected analysis content (checking common patterns)
|
||||||
analysis_text = json.dumps(expert_analysis).lower()
|
analysis_text = json.dumps(expert_analysis, ensure_ascii=False).lower()
|
||||||
|
|
||||||
# Look for code review identification
|
# Look for code review identification
|
||||||
review_indicators = ["security", "vulnerability", "performance", "critical", "api", "key"]
|
review_indicators = ["security", "vulnerability", "performance", "critical", "api", "key"]
|
||||||
|
|||||||
@@ -385,7 +385,7 @@ RuntimeError: dictionary changed size during iteration
|
|||||||
expert_analysis = response_final_data.get("expert_analysis", {})
|
expert_analysis = response_final_data.get("expert_analysis", {})
|
||||||
|
|
||||||
# Check for expected analysis content (checking common patterns)
|
# Check for expected analysis content (checking common patterns)
|
||||||
analysis_text = json.dumps(expert_analysis).lower()
|
analysis_text = json.dumps(expert_analysis, ensure_ascii=False).lower()
|
||||||
|
|
||||||
# Look for bug identification
|
# Look for bug identification
|
||||||
bug_indicators = ["dictionary", "iteration", "modify", "runtime", "error", "del"]
|
bug_indicators = ["dictionary", "iteration", "modify", "runtime", "error", "del"]
|
||||||
|
|||||||
@@ -430,7 +430,7 @@ REQUIREMENTS:
|
|||||||
expert_analysis = response_final_data.get("expert_analysis", {})
|
expert_analysis = response_final_data.get("expert_analysis", {})
|
||||||
|
|
||||||
# Check for expected analysis content (checking common patterns)
|
# Check for expected analysis content (checking common patterns)
|
||||||
analysis_text = json.dumps(expert_analysis).lower()
|
analysis_text = json.dumps(expert_analysis, ensure_ascii=False).lower()
|
||||||
|
|
||||||
# Look for security issue identification
|
# Look for security issue identification
|
||||||
security_indicators = ["sql", "injection", "security", "hardcoded", "secret", "authentication"]
|
security_indicators = ["sql", "injection", "security", "hardcoded", "secret", "authentication"]
|
||||||
|
|||||||
@@ -125,7 +125,7 @@ class DataProcessorManager:
|
|||||||
# Code smell: Duplicate date formatting logic
|
# Code smell: Duplicate date formatting logic
|
||||||
if output_format == 'json':
|
if output_format == 'json':
|
||||||
processed_data['processed_at'] = datetime.now().strftime('%Y-%m-%d %H:%M:%S')
|
processed_data['processed_at'] = datetime.now().strftime('%Y-%m-%d %H:%M:%S')
|
||||||
result = json.dumps(processed_data)
|
result = json.dumps(processed_data, ensure_ascii=False)
|
||||||
elif output_format == 'csv':
|
elif output_format == 'csv':
|
||||||
processed_data['processed_at'] = datetime.now().strftime('%Y-%m-%d %H:%M:%S')
|
processed_data['processed_at'] = datetime.now().strftime('%Y-%m-%d %H:%M:%S')
|
||||||
result = f"{processed_data['full_name']},{processed_data['email_domain']},{processed_data['age_category']}"
|
result = f"{processed_data['full_name']},{processed_data['email_domain']},{processed_data['age_category']}"
|
||||||
@@ -580,7 +580,7 @@ class UserData:
|
|||||||
self.logger.error("Missing expert_analysis in final response")
|
self.logger.error("Missing expert_analysis in final response")
|
||||||
return False
|
return False
|
||||||
expert_analysis = response_final_data.get("expert_analysis", {})
|
expert_analysis = response_final_data.get("expert_analysis", {})
|
||||||
analysis_content = json.dumps(expert_analysis).lower()
|
analysis_content = json.dumps(expert_analysis, ensure_ascii=False).lower()
|
||||||
elif actual_status == "files_required_to_continue":
|
elif actual_status == "files_required_to_continue":
|
||||||
# For files_required_to_continue, analysis is in content field
|
# For files_required_to_continue, analysis is in content field
|
||||||
if "content" not in response_final_data:
|
if "content" not in response_final_data:
|
||||||
@@ -708,7 +708,7 @@ def format_output(data, format_type):
|
|||||||
\"\"\"Format output - duplicate logic\"\"\"
|
\"\"\"Format output - duplicate logic\"\"\"
|
||||||
if format_type == 'json':
|
if format_type == 'json':
|
||||||
import json
|
import json
|
||||||
return json.dumps(data)
|
return json.dumps(data, ensure_ascii=False)
|
||||||
elif format_type == 'csv':
|
elif format_type == 'csv':
|
||||||
return ','.join(str(v) for v in data.values())
|
return ','.join(str(v) for v in data.values())
|
||||||
else:
|
else:
|
||||||
|
|||||||
@@ -346,7 +346,7 @@ class TestCalculatorBasic:
|
|||||||
expert_analysis = response_final_data.get("expert_analysis", {})
|
expert_analysis = response_final_data.get("expert_analysis", {})
|
||||||
|
|
||||||
# Check for expected analysis content
|
# Check for expected analysis content
|
||||||
analysis_text = json.dumps(expert_analysis).lower()
|
analysis_text = json.dumps(expert_analysis, ensure_ascii=False).lower()
|
||||||
|
|
||||||
# Look for test generation indicators
|
# Look for test generation indicators
|
||||||
test_indicators = ["test", "edge", "boundary", "error", "coverage", "pytest"]
|
test_indicators = ["test", "edge", "boundary", "error", "coverage", "pytest"]
|
||||||
|
|||||||
@@ -415,7 +415,7 @@ class ThinkDeepWorkflowValidationTest(ConversationBaseTest):
|
|||||||
expert_analysis = {"analysis": expert_analysis}
|
expert_analysis = {"analysis": expert_analysis}
|
||||||
|
|
||||||
# Check for expected analysis content (checking common patterns)
|
# Check for expected analysis content (checking common patterns)
|
||||||
analysis_text = json.dumps(expert_analysis).lower()
|
analysis_text = json.dumps(expert_analysis, ensure_ascii=False).lower()
|
||||||
|
|
||||||
# Look for thinking analysis validation
|
# Look for thinking analysis validation
|
||||||
thinking_indicators = ["migration", "strategy", "microservices", "risk", "approach", "implementation"]
|
thinking_indicators = ["migration", "strategy", "microservices", "risk", "approach", "implementation"]
|
||||||
|
|||||||
@@ -1,30 +1,32 @@
|
|||||||
#!/usr/bin/env python3
|
#!/usr/bin/env python3
|
||||||
from flask import Flask, request, jsonify
|
|
||||||
import os
|
import os
|
||||||
import subprocess
|
import subprocess
|
||||||
|
|
||||||
import requests
|
import requests
|
||||||
|
from flask import Flask, jsonify, request
|
||||||
|
|
||||||
app = Flask(__name__)
|
app = Flask(__name__)
|
||||||
|
|
||||||
# A05: Security Misconfiguration - Debug mode enabled
|
# A05: Security Misconfiguration - Debug mode enabled
|
||||||
app.config['DEBUG'] = True
|
app.config["DEBUG"] = True
|
||||||
app.config['SECRET_KEY'] = 'dev-secret-key' # Hardcoded secret
|
app.config["SECRET_KEY"] = "dev-secret-key" # Hardcoded secret
|
||||||
|
|
||||||
@app.route('/api/search', methods=['GET'])
|
|
||||||
|
@app.route("/api/search", methods=["GET"])
|
||||||
def search():
|
def search():
|
||||||
'''Search endpoint with multiple vulnerabilities'''
|
"""Search endpoint with multiple vulnerabilities"""
|
||||||
# A03: Injection - XSS vulnerability, no input sanitization
|
# A03: Injection - XSS vulnerability, no input sanitization
|
||||||
query = request.args.get('q', '')
|
query = request.args.get("q", "")
|
||||||
|
|
||||||
# A03: Injection - Command injection vulnerability
|
# A03: Injection - Command injection vulnerability
|
||||||
if 'file:' in query:
|
if "file:" in query:
|
||||||
filename = query.split('file:')[1]
|
filename = query.split("file:")[1]
|
||||||
# Direct command execution
|
# Direct command execution
|
||||||
result = subprocess.run(f"cat {filename}", shell=True, capture_output=True, text=True)
|
result = subprocess.run(f"cat {filename}", shell=True, capture_output=True, text=True)
|
||||||
return jsonify({"result": result.stdout})
|
return jsonify({"result": result.stdout})
|
||||||
|
|
||||||
# A10: Server-Side Request Forgery (SSRF)
|
# A10: Server-Side Request Forgery (SSRF)
|
||||||
if query.startswith('http'):
|
if query.startswith("http"):
|
||||||
# No validation of URL, allows internal network access
|
# No validation of URL, allows internal network access
|
||||||
response = requests.get(query)
|
response = requests.get(query)
|
||||||
return jsonify({"content": response.text})
|
return jsonify({"content": response.text})
|
||||||
@@ -32,39 +34,42 @@ def search():
|
|||||||
# Return search results without output encoding
|
# Return search results without output encoding
|
||||||
return f"<h1>Search Results for: {query}</h1>"
|
return f"<h1>Search Results for: {query}</h1>"
|
||||||
|
|
||||||
@app.route('/api/admin', methods=['GET'])
|
|
||||||
|
@app.route("/api/admin", methods=["GET"])
|
||||||
def admin_panel():
|
def admin_panel():
|
||||||
'''Admin panel with broken access control'''
|
"""Admin panel with broken access control"""
|
||||||
# A01: Broken Access Control - No authentication check
|
# A01: Broken Access Control - No authentication check
|
||||||
# Anyone can access admin functionality
|
# Anyone can access admin functionality
|
||||||
action = request.args.get('action')
|
action = request.args.get("action")
|
||||||
|
|
||||||
if action == 'delete_user':
|
if action == "delete_user":
|
||||||
user_id = request.args.get('user_id')
|
user_id = request.args.get("user_id")
|
||||||
# Performs privileged action without authorization
|
# Performs privileged action without authorization
|
||||||
return jsonify({"status": "User deleted", "user_id": user_id})
|
return jsonify({"status": "User deleted", "user_id": user_id})
|
||||||
|
|
||||||
return jsonify({"status": "Admin panel"})
|
return jsonify({"status": "Admin panel"})
|
||||||
|
|
||||||
@app.route('/api/upload', methods=['POST'])
|
|
||||||
|
@app.route("/api/upload", methods=["POST"])
|
||||||
def upload_file():
|
def upload_file():
|
||||||
'''File upload with security issues'''
|
"""File upload with security issues"""
|
||||||
# A05: Security Misconfiguration - No file type validation
|
# A05: Security Misconfiguration - No file type validation
|
||||||
file = request.files.get('file')
|
file = request.files.get("file")
|
||||||
if file:
|
if file:
|
||||||
# Saves any file type to server
|
# Saves any file type to server
|
||||||
filename = file.filename
|
filename = file.filename
|
||||||
file.save(os.path.join('/tmp', filename))
|
file.save(os.path.join("/tmp", filename))
|
||||||
|
|
||||||
# A03: Path traversal vulnerability
|
# A03: Path traversal vulnerability
|
||||||
return jsonify({"status": "File uploaded", "path": f"/tmp/{filename}"})
|
return jsonify({"status": "File uploaded", "path": f"/tmp/{filename}"})
|
||||||
|
|
||||||
return jsonify({"error": "No file provided"})
|
return jsonify({"error": "No file provided"})
|
||||||
|
|
||||||
|
|
||||||
# A06: Vulnerable and Outdated Components
|
# A06: Vulnerable and Outdated Components
|
||||||
# Using old Flask version with known vulnerabilities (hypothetical)
|
# Using old Flask version with known vulnerabilities (hypothetical)
|
||||||
# requirements.txt: Flask==0.12.2 (known security issues)
|
# requirements.txt: Flask==0.12.2 (known security issues)
|
||||||
|
|
||||||
if __name__ == '__main__':
|
if __name__ == "__main__":
|
||||||
# A05: Security Misconfiguration - Running on all interfaces
|
# A05: Security Misconfiguration - Running on all interfaces
|
||||||
app.run(host='0.0.0.0', port=5000, debug=True)
|
app.run(host="0.0.0.0", port=5000, debug=True)
|
||||||
|
|||||||
@@ -2,15 +2,16 @@
|
|||||||
import hashlib
|
import hashlib
|
||||||
import pickle
|
import pickle
|
||||||
import sqlite3
|
import sqlite3
|
||||||
from flask import request, session
|
|
||||||
|
|
||||||
class AuthenticationManager:
|
class AuthenticationManager:
|
||||||
def __init__(self, db_path="users.db"):
|
def __init__(self, db_path="users.db"):
|
||||||
# A01: Broken Access Control - No proper session management
|
# A01: Broken Access Control - No proper session management
|
||||||
self.db_path = db_path
|
self.db_path = db_path
|
||||||
self.sessions = {} # In-memory session storage
|
self.sessions = {} # In-memory session storage
|
||||||
|
|
||||||
def login(self, username, password):
|
def login(self, username, password):
|
||||||
'''User login with various security vulnerabilities'''
|
"""User login with various security vulnerabilities"""
|
||||||
# A03: Injection - SQL injection vulnerability
|
# A03: Injection - SQL injection vulnerability
|
||||||
conn = sqlite3.connect(self.db_path)
|
conn = sqlite3.connect(self.db_path)
|
||||||
cursor = conn.cursor()
|
cursor = conn.cursor()
|
||||||
@@ -36,7 +37,7 @@ class AuthenticationManager:
|
|||||||
return {"status": "failed", "message": "Invalid password"}
|
return {"status": "failed", "message": "Invalid password"}
|
||||||
|
|
||||||
def reset_password(self, email):
|
def reset_password(self, email):
|
||||||
'''Password reset with security issues'''
|
"""Password reset with security issues"""
|
||||||
# A04: Insecure Design - No rate limiting or validation
|
# A04: Insecure Design - No rate limiting or validation
|
||||||
reset_token = hashlib.md5(email.encode()).hexdigest()
|
reset_token = hashlib.md5(email.encode()).hexdigest()
|
||||||
|
|
||||||
@@ -45,12 +46,12 @@ class AuthenticationManager:
|
|||||||
return {"reset_token": reset_token, "url": f"/reset?token={reset_token}"}
|
return {"reset_token": reset_token, "url": f"/reset?token={reset_token}"}
|
||||||
|
|
||||||
def deserialize_user_data(self, data):
|
def deserialize_user_data(self, data):
|
||||||
'''Unsafe deserialization'''
|
"""Unsafe deserialization"""
|
||||||
# A08: Software and Data Integrity Failures - Insecure deserialization
|
# A08: Software and Data Integrity Failures - Insecure deserialization
|
||||||
return pickle.loads(data)
|
return pickle.loads(data)
|
||||||
|
|
||||||
def get_user_profile(self, user_id):
|
def get_user_profile(self, user_id):
|
||||||
'''Get user profile with authorization issues'''
|
"""Get user profile with authorization issues"""
|
||||||
# A01: Broken Access Control - No authorization check
|
# A01: Broken Access Control - No authorization check
|
||||||
conn = sqlite3.connect(self.db_path)
|
conn = sqlite3.connect(self.db_path)
|
||||||
cursor = conn.cursor()
|
cursor = conn.cursor()
|
||||||
|
|||||||
@@ -2,11 +2,13 @@
|
|||||||
Sample Python module for testing MCP conversation continuity
|
Sample Python module for testing MCP conversation continuity
|
||||||
"""
|
"""
|
||||||
|
|
||||||
|
|
||||||
def fibonacci(n):
|
def fibonacci(n):
|
||||||
"""Calculate fibonacci number recursively"""
|
"""Calculate fibonacci number recursively"""
|
||||||
if n <= 1:
|
if n <= 1:
|
||||||
return n
|
return n
|
||||||
return fibonacci(n-1) + fibonacci(n-2)
|
return fibonacci(n - 1) + fibonacci(n - 2)
|
||||||
|
|
||||||
|
|
||||||
def factorial(n):
|
def factorial(n):
|
||||||
"""Calculate factorial iteratively"""
|
"""Calculate factorial iteratively"""
|
||||||
@@ -15,6 +17,7 @@ def factorial(n):
|
|||||||
result *= i
|
result *= i
|
||||||
return result
|
return result
|
||||||
|
|
||||||
|
|
||||||
class Calculator:
|
class Calculator:
|
||||||
"""Simple calculator class"""
|
"""Simple calculator class"""
|
||||||
|
|
||||||
|
|||||||
@@ -34,7 +34,8 @@ class TestDynamicContextRequests:
|
|||||||
"status": "files_required_to_continue",
|
"status": "files_required_to_continue",
|
||||||
"mandatory_instructions": "I need to see the package.json file to understand dependencies",
|
"mandatory_instructions": "I need to see the package.json file to understand dependencies",
|
||||||
"files_needed": ["package.json", "package-lock.json"],
|
"files_needed": ["package.json", "package-lock.json"],
|
||||||
}
|
},
|
||||||
|
ensure_ascii=False,
|
||||||
)
|
)
|
||||||
|
|
||||||
mock_provider = create_mock_provider()
|
mock_provider = create_mock_provider()
|
||||||
@@ -174,7 +175,8 @@ class TestDynamicContextRequests:
|
|||||||
],
|
],
|
||||||
},
|
},
|
||||||
},
|
},
|
||||||
}
|
},
|
||||||
|
ensure_ascii=False,
|
||||||
)
|
)
|
||||||
|
|
||||||
mock_provider = create_mock_provider()
|
mock_provider = create_mock_provider()
|
||||||
@@ -339,7 +341,8 @@ class TestCollaborationWorkflow:
|
|||||||
"status": "files_required_to_continue",
|
"status": "files_required_to_continue",
|
||||||
"mandatory_instructions": "I need to see the package.json file to analyze npm dependencies",
|
"mandatory_instructions": "I need to see the package.json file to analyze npm dependencies",
|
||||||
"files_needed": ["package.json", "package-lock.json"],
|
"files_needed": ["package.json", "package-lock.json"],
|
||||||
}
|
},
|
||||||
|
ensure_ascii=False,
|
||||||
)
|
)
|
||||||
|
|
||||||
mock_provider = create_mock_provider()
|
mock_provider = create_mock_provider()
|
||||||
@@ -405,7 +408,8 @@ class TestCollaborationWorkflow:
|
|||||||
"status": "files_required_to_continue",
|
"status": "files_required_to_continue",
|
||||||
"mandatory_instructions": "I need to see the configuration file to understand the connection settings",
|
"mandatory_instructions": "I need to see the configuration file to understand the connection settings",
|
||||||
"files_needed": ["config.py"],
|
"files_needed": ["config.py"],
|
||||||
}
|
},
|
||||||
|
ensure_ascii=False,
|
||||||
)
|
)
|
||||||
|
|
||||||
mock_provider = create_mock_provider()
|
mock_provider = create_mock_provider()
|
||||||
|
|||||||
481
tests/test_integration_utf8.py
Normal file
481
tests/test_integration_utf8.py
Normal file
@@ -0,0 +1,481 @@
|
|||||||
|
"""
|
||||||
|
Full integration test script to validate UTF-8 implementation
|
||||||
|
and French localization.
|
||||||
|
|
||||||
|
This script runs all unit tests and checks full integration.
|
||||||
|
"""
|
||||||
|
|
||||||
|
import json
|
||||||
|
import os
|
||||||
|
import subprocess
|
||||||
|
import sys
|
||||||
|
import tempfile
|
||||||
|
from pathlib import Path
|
||||||
|
|
||||||
|
|
||||||
|
def run_utf8_integration_tests():
|
||||||
|
"""Run UTF-8 integration tests."""
|
||||||
|
print("🚀 Starting UTF-8 integration tests")
|
||||||
|
print("=" * 60)
|
||||||
|
|
||||||
|
# Test environment setup
|
||||||
|
os.environ["LOCALE"] = "fr-FR"
|
||||||
|
os.environ["GEMINI_API_KEY"] = "dummy-key-for-tests"
|
||||||
|
os.environ["OPENAI_API_KEY"] = "dummy-key-for-tests"
|
||||||
|
|
||||||
|
# Test 1: Validate UTF-8 characters in json.dumps
|
||||||
|
print("\n1️⃣ UTF-8 encoding test with json.dumps")
|
||||||
|
test_utf8_json_encoding()
|
||||||
|
|
||||||
|
# Test 2: Validate language instruction generation
|
||||||
|
print("\n2️⃣ Language instruction generation test")
|
||||||
|
test_language_instruction_generation()
|
||||||
|
|
||||||
|
# Test 3: Validate UTF-8 file handling
|
||||||
|
print("\n3️⃣ UTF-8 file handling test")
|
||||||
|
test_file_utf8_handling()
|
||||||
|
|
||||||
|
# Test 4: Validate MCP tools integration
|
||||||
|
print("\n4️⃣ MCP tools integration test")
|
||||||
|
test_mcp_tools_integration()
|
||||||
|
|
||||||
|
# Test 5: Run unit tests
|
||||||
|
print("\n5️⃣ Running unit tests")
|
||||||
|
run_unit_tests()
|
||||||
|
|
||||||
|
print("\n✅ All UTF-8 integration tests completed!")
|
||||||
|
print("🇫🇷 French localization works correctly!")
|
||||||
|
|
||||||
|
|
||||||
|
def test_utf8_json_encoding():
|
||||||
|
"""Test UTF-8 encoding with json.dumps(ensure_ascii=False)."""
|
||||||
|
print(" Testing UTF-8 JSON encoding...")
|
||||||
|
|
||||||
|
# Test data with French characters and emojis
|
||||||
|
test_data = {
|
||||||
|
"analyse": {
|
||||||
|
"statut": "terminée",
|
||||||
|
"résultat": "Aucun problème critique détecté",
|
||||||
|
"recommandations": [
|
||||||
|
"Améliorer la documentation",
|
||||||
|
"Optimiser les performances",
|
||||||
|
"Ajouter des tests unitaires",
|
||||||
|
],
|
||||||
|
"métadonnées": {
|
||||||
|
"créé_par": "Développeur Principal",
|
||||||
|
"date_création": "2024-01-01",
|
||||||
|
"dernière_modification": "2024-01-15",
|
||||||
|
},
|
||||||
|
"émojis_status": {
|
||||||
|
"critique": "🔴",
|
||||||
|
"élevé": "🟠",
|
||||||
|
"moyen": "🟡",
|
||||||
|
"faible": "🟢",
|
||||||
|
"succès": "✅",
|
||||||
|
"erreur": "❌",
|
||||||
|
},
|
||||||
|
},
|
||||||
|
"outils": [
|
||||||
|
{"nom": "analyse", "description": "Analyse architecturale avancée"},
|
||||||
|
{"nom": "révision", "description": "Révision de code automatisée"},
|
||||||
|
{"nom": "génération", "description": "Génération de documentation"},
|
||||||
|
],
|
||||||
|
}
|
||||||
|
|
||||||
|
# Test with ensure_ascii=False
|
||||||
|
json_correct = json.dumps(test_data, ensure_ascii=False, indent=2)
|
||||||
|
|
||||||
|
# Checks
|
||||||
|
utf8_terms = [
|
||||||
|
"terminée",
|
||||||
|
"résultat",
|
||||||
|
"détecté",
|
||||||
|
"Améliorer",
|
||||||
|
"créé_par",
|
||||||
|
"Développeur",
|
||||||
|
"création",
|
||||||
|
"métadonnées",
|
||||||
|
"dernière",
|
||||||
|
"émojis_status",
|
||||||
|
"élevé",
|
||||||
|
"révision",
|
||||||
|
"génération",
|
||||||
|
]
|
||||||
|
|
||||||
|
emojis = ["🔴", "🟠", "🟡", "🟢", "✅", "❌"]
|
||||||
|
|
||||||
|
for term in utf8_terms:
|
||||||
|
assert term in json_correct, f"Missing UTF-8 term: {term}"
|
||||||
|
|
||||||
|
for emoji in emojis:
|
||||||
|
assert emoji in json_correct, f"Missing emoji: {emoji}"
|
||||||
|
|
||||||
|
# Check for escaped characters
|
||||||
|
assert "\\u" not in json_correct, "Escaped Unicode characters detected!"
|
||||||
|
|
||||||
|
# Test parsing
|
||||||
|
parsed = json.loads(json_correct)
|
||||||
|
assert parsed["analyse"]["statut"] == "terminée"
|
||||||
|
assert parsed["analyse"]["émojis_status"]["critique"] == "🔴"
|
||||||
|
|
||||||
|
print(" ✅ UTF-8 JSON encoding: SUCCESS")
|
||||||
|
|
||||||
|
|
||||||
|
def test_language_instruction_generation():
|
||||||
|
"""Test language instruction generation."""
|
||||||
|
print(" Testing language instruction generation...")
|
||||||
|
|
||||||
|
# Simulation of get_language_instruction
|
||||||
|
def get_language_instruction():
|
||||||
|
locale = os.getenv("LOCALE", "").strip()
|
||||||
|
if not locale:
|
||||||
|
return ""
|
||||||
|
return f"Always respond in {locale}.\n\n"
|
||||||
|
|
||||||
|
# Test with different locales
|
||||||
|
test_locales = [
|
||||||
|
("fr-FR", "French"),
|
||||||
|
("en-US", "English"),
|
||||||
|
("es-ES", "Spanish"),
|
||||||
|
("de-DE", "German"),
|
||||||
|
("", "none"),
|
||||||
|
]
|
||||||
|
|
||||||
|
for locale, description in test_locales:
|
||||||
|
os.environ["LOCALE"] = locale
|
||||||
|
instruction = get_language_instruction()
|
||||||
|
|
||||||
|
if locale:
|
||||||
|
assert locale in instruction, f"Missing {locale} in instruction"
|
||||||
|
assert instruction.endswith("\n\n"), "Incorrect instruction format"
|
||||||
|
print(f" 📍 {description}: {instruction.strip()}")
|
||||||
|
else:
|
||||||
|
assert instruction == "", "Empty instruction expected for empty locale"
|
||||||
|
print(f" 📍 {description}: (empty)")
|
||||||
|
|
||||||
|
# Restore French locale
|
||||||
|
os.environ["LOCALE"] = "fr-FR"
|
||||||
|
print(" ✅ Language instruction generation: SUCCESS")
|
||||||
|
|
||||||
|
|
||||||
|
def test_file_utf8_handling():
|
||||||
|
"""Test handling of files with UTF-8 content."""
|
||||||
|
print(" Testing UTF-8 file handling...")
|
||||||
|
|
||||||
|
# File content with French characters
|
||||||
|
french_content = '''#!/usr/bin/env python3
|
||||||
|
"""
|
||||||
|
Module de gestion des préférences utilisateur.
|
||||||
|
Développé par: Équipe Technique
|
||||||
|
Date de création: 15 décembre 2024
|
||||||
|
"""
|
||||||
|
|
||||||
|
import json
|
||||||
|
from typing import Dict, Optional
|
||||||
|
|
||||||
|
class GestionnairePreferences:
|
||||||
|
"""Gestionnaire des préférences utilisateur avec support UTF-8."""
|
||||||
|
|
||||||
|
def __init__(self):
|
||||||
|
self.données = {}
|
||||||
|
self.historique = []
|
||||||
|
|
||||||
|
def définir_préférence(self, clé: str, valeur) -> bool:
|
||||||
|
"""
|
||||||
|
Définit une préférence utilisateur.
|
||||||
|
|
||||||
|
Args:
|
||||||
|
clé: Identifiant de la préférence
|
||||||
|
valeur: Valeur à enregistrer
|
||||||
|
|
||||||
|
Returns:
|
||||||
|
True si la préférence a été définie avec succès
|
||||||
|
"""
|
||||||
|
try:
|
||||||
|
self.données[clé] = valeur
|
||||||
|
self.historique.append({
|
||||||
|
"action": "définition",
|
||||||
|
"clé": clé,
|
||||||
|
"horodatage": "2024-01-01T12:00:00Z"
|
||||||
|
})
|
||||||
|
return True
|
||||||
|
except Exception as e:
|
||||||
|
print(f"Error setting preference: {e}")
|
||||||
|
return False
|
||||||
|
|
||||||
|
def obtenir_préférence(self, clé: str) -> Optional:
|
||||||
|
"""Récupère une préférence par sa clé."""
|
||||||
|
return self.données.get(clé)
|
||||||
|
|
||||||
|
def exporter_données(self) -> str:
|
||||||
|
"""Exporte les données en JSON UTF-8."""
|
||||||
|
return json.dumps(self.données, ensure_ascii=False, indent=2)
|
||||||
|
|
||||||
|
# Configuration par défaut avec caractères UTF-8
|
||||||
|
CONFIG_DÉFAUT = {
|
||||||
|
"langue": "français",
|
||||||
|
"région": "France",
|
||||||
|
"thème": "sombre",
|
||||||
|
"notifications": "activées"
|
||||||
|
}
|
||||||
|
|
||||||
|
def créer_gestionnaire() -> GestionnairePreferences:
|
||||||
|
"""Crée une instance du gestionnaire."""
|
||||||
|
gestionnaire = GestionnairePreferences()
|
||||||
|
|
||||||
|
# Application de la configuration par défaut
|
||||||
|
for clé, valeur in CONFIG_DÉFAUT.items():
|
||||||
|
gestionnaire.définir_préférence(clé, valeur)
|
||||||
|
|
||||||
|
return gestionnaire
|
||||||
|
|
||||||
|
if __name__ == "__main__":
|
||||||
|
# Test d'utilisation
|
||||||
|
gestionnaire = créer_gestionnaire()
|
||||||
|
print("Gestionnaire créé avec succès! 🎉")
|
||||||
|
print(f"Données: {gestionnaire.exporter_données()}")
|
||||||
|
'''
|
||||||
|
|
||||||
|
# Test writing and reading UTF-8
|
||||||
|
with tempfile.NamedTemporaryFile(mode="w", encoding="utf-8", suffix=".py", delete=False) as f:
|
||||||
|
f.write(french_content)
|
||||||
|
temp_file = f.name
|
||||||
|
|
||||||
|
try:
|
||||||
|
# Test reading
|
||||||
|
with open(temp_file, encoding="utf-8") as f:
|
||||||
|
read_content = f.read()
|
||||||
|
|
||||||
|
# Checks
|
||||||
|
assert read_content == french_content, "Altered UTF-8 content"
|
||||||
|
|
||||||
|
# Check specific terms
|
||||||
|
utf8_terms = [
|
||||||
|
"préférences",
|
||||||
|
"Développé",
|
||||||
|
"Équipe",
|
||||||
|
"création",
|
||||||
|
"données",
|
||||||
|
"définir_préférence",
|
||||||
|
"horodatage",
|
||||||
|
"Récupère",
|
||||||
|
"français",
|
||||||
|
"activées",
|
||||||
|
"créer_gestionnaire",
|
||||||
|
"succès",
|
||||||
|
]
|
||||||
|
|
||||||
|
for term in utf8_terms:
|
||||||
|
assert term in read_content, f"Missing UTF-8 term: {term}"
|
||||||
|
|
||||||
|
print(" ✅ UTF-8 file handling: SUCCESS")
|
||||||
|
|
||||||
|
finally:
|
||||||
|
# Cleanup
|
||||||
|
os.unlink(temp_file)
|
||||||
|
|
||||||
|
|
||||||
|
def test_mcp_tools_integration():
|
||||||
|
"""Test MCP tools integration with UTF-8."""
|
||||||
|
print(" Testing MCP tools integration...")
|
||||||
|
|
||||||
|
# Simulation of MCP tool response
|
||||||
|
def simulate_mcp_tool_response():
|
||||||
|
"""Simulate MCP tool response with UTF-8 content."""
|
||||||
|
response_data = {
|
||||||
|
"status": "success",
|
||||||
|
"content_type": "markdown",
|
||||||
|
"content": """# Analyse Terminée avec Succès ✅
|
||||||
|
|
||||||
|
## Résumé de l'Analyse
|
||||||
|
|
||||||
|
L'analyse architecturale du projet a été **terminée** avec succès. Voici les principaux résultats :
|
||||||
|
|
||||||
|
### 🎯 Objectifs Atteints
|
||||||
|
- ✅ Révision complète du code
|
||||||
|
- ✅ Identification des problèmes de performance
|
||||||
|
- ✅ Recommandations d'amélioration générées
|
||||||
|
|
||||||
|
### 📊 Métriques Analysées
|
||||||
|
| Métrique | Valeur | Statut |
|
||||||
|
|----------|--------|--------|
|
||||||
|
| Complexité cyclomatique | 12 | 🟡 Acceptable |
|
||||||
|
| Couverture de tests | 85% | 🟢 Bon |
|
||||||
|
| Dépendances externes | 23 | 🟠 À réviser |
|
||||||
|
|
||||||
|
### 🔍 Problèmes Identifiés
|
||||||
|
|
||||||
|
#### 🔴 Critique
|
||||||
|
Aucun problème critique détecté.
|
||||||
|
|
||||||
|
#### 🟠 Élevé
|
||||||
|
1. **Performance des requêtes** : Optimisation nécessaire
|
||||||
|
2. **Gestion mémoire** : Fuites potentielles détectées
|
||||||
|
|
||||||
|
#### 🟡 Moyen
|
||||||
|
1. **Documentation** : Certaines fonctions manquent de commentaires
|
||||||
|
2. **Tests unitaires** : Couverture à améliorer
|
||||||
|
|
||||||
|
### <20> Détails de l'Analyse
|
||||||
|
|
||||||
|
Pour plus de détails sur chaque problème identifié, consultez les recommandations ci-dessous.
|
||||||
|
|
||||||
|
### <20>🚀 Recommandations Prioritaires
|
||||||
|
|
||||||
|
1. **Optimisation DB** : Implémenter un cache Redis
|
||||||
|
2. **Refactoring** : Séparer les responsabilités
|
||||||
|
3. **Documentation** : Ajouter les docstrings manquantes
|
||||||
|
4. **Tests** : Augmenter la couverture à 90%+
|
||||||
|
|
||||||
|
### 📈 Prochaines Étapes
|
||||||
|
|
||||||
|
- [ ] Implémenter le système de cache
|
||||||
|
- [ ] Refactorer les modules identifiés
|
||||||
|
- [ ] Compléter la documentation
|
||||||
|
- [ ] Exécuter les tests de régression
|
||||||
|
|
||||||
|
---
|
||||||
|
*Analyse générée automatiquement par MCP Zen* 🤖
|
||||||
|
""",
|
||||||
|
"metadata": {
|
||||||
|
"tool_name": "analyze",
|
||||||
|
"execution_time": 2.5,
|
||||||
|
"locale": "fr-FR",
|
||||||
|
"timestamp": "2024-01-01T12:00:00Z",
|
||||||
|
"analysis_summary": {
|
||||||
|
"files_analyzed": 15,
|
||||||
|
"issues_found": 4,
|
||||||
|
"recommendations": 4,
|
||||||
|
"overall_score": "B+ (Good level)",
|
||||||
|
},
|
||||||
|
},
|
||||||
|
"continuation_offer": {
|
||||||
|
"continuation_id": "analysis-123",
|
||||||
|
"note": "In-depth analysis available with more details",
|
||||||
|
},
|
||||||
|
}
|
||||||
|
|
||||||
|
# Serialization with ensure_ascii=False
|
||||||
|
json_response = json.dumps(response_data, ensure_ascii=False, indent=2)
|
||||||
|
|
||||||
|
# UTF-8 checks
|
||||||
|
utf8_checks = [
|
||||||
|
"Terminée",
|
||||||
|
"Succès",
|
||||||
|
"Résumé",
|
||||||
|
"terminée",
|
||||||
|
"Atteints",
|
||||||
|
"Révision",
|
||||||
|
"problèmes",
|
||||||
|
"générées",
|
||||||
|
"Métriques",
|
||||||
|
"Identifiés",
|
||||||
|
"détecté",
|
||||||
|
"Élevé",
|
||||||
|
"nécessaire",
|
||||||
|
"détectées",
|
||||||
|
"améliorer",
|
||||||
|
"Prioritaires",
|
||||||
|
"responsabilités",
|
||||||
|
"Étapes",
|
||||||
|
"régression",
|
||||||
|
"générée",
|
||||||
|
"détails",
|
||||||
|
]
|
||||||
|
|
||||||
|
for term in utf8_checks:
|
||||||
|
assert term in json_response, f"Missing UTF-8 term: {term}"
|
||||||
|
|
||||||
|
# Emoji check
|
||||||
|
emojis = ["✅", "🎯", "📊", "🟡", "🟢", "🟠", "🔍", "🔴", "🚀", "📈", "🤖"]
|
||||||
|
for emoji in emojis:
|
||||||
|
assert emoji in json_response, f"Missing emoji: {emoji}"
|
||||||
|
|
||||||
|
# Test parsing
|
||||||
|
parsed = json.loads(json_response)
|
||||||
|
assert parsed["status"] == "success"
|
||||||
|
assert "Terminée" in parsed["content"]
|
||||||
|
assert parsed["metadata"]["locale"] == "fr-FR"
|
||||||
|
|
||||||
|
return json_response
|
||||||
|
|
||||||
|
# Test simulation
|
||||||
|
response = simulate_mcp_tool_response()
|
||||||
|
assert len(response) > 1000, "MCP response too short"
|
||||||
|
|
||||||
|
print(" ✅ MCP tools integration: SUCCESS")
|
||||||
|
|
||||||
|
|
||||||
|
def run_unit_tests():
|
||||||
|
"""Run unit tests."""
|
||||||
|
print(" Running unit tests...")
|
||||||
|
|
||||||
|
# List of test files to run
|
||||||
|
test_files = ["test_utf8_localization.py", "test_provider_utf8.py", "test_workflow_utf8.py"]
|
||||||
|
|
||||||
|
current_dir = Path(__file__).parent
|
||||||
|
test_results = []
|
||||||
|
|
||||||
|
for test_file in test_files:
|
||||||
|
test_path = current_dir / test_file
|
||||||
|
if test_path.exists():
|
||||||
|
print(f" 📝 Running {test_file}...")
|
||||||
|
try:
|
||||||
|
# Test execution
|
||||||
|
result = subprocess.run(
|
||||||
|
[sys.executable, "-m", "unittest", test_file.replace(".py", ""), "-v"],
|
||||||
|
cwd=current_dir,
|
||||||
|
capture_output=True,
|
||||||
|
text=True,
|
||||||
|
timeout=60,
|
||||||
|
)
|
||||||
|
|
||||||
|
if result.returncode == 0:
|
||||||
|
print(f" ✅ {test_file}: SUCCESS")
|
||||||
|
test_results.append((test_file, "SUCCESS"))
|
||||||
|
else:
|
||||||
|
print(f" ❌ {test_file}: FAILURE")
|
||||||
|
print(f" Error: {result.stderr[:200]}...")
|
||||||
|
test_results.append((test_file, "FAILURE"))
|
||||||
|
|
||||||
|
except subprocess.TimeoutExpired:
|
||||||
|
print(f" ⏰ {test_file}: TIMEOUT")
|
||||||
|
test_results.append((test_file, "TIMEOUT"))
|
||||||
|
except Exception as e:
|
||||||
|
print(f" 💥 {test_file}: ERROR - {e}")
|
||||||
|
test_results.append((test_file, "ERROR"))
|
||||||
|
else:
|
||||||
|
print(f" ⚠️ {test_file}: NOT FOUND")
|
||||||
|
test_results.append((test_file, "NOT FOUND"))
|
||||||
|
|
||||||
|
# Test summary
|
||||||
|
print("\n 📋 Unit test summary:")
|
||||||
|
for test_file, status in test_results:
|
||||||
|
status_emoji = {"SUCCESS": "✅", "FAILURE": "❌", "TIMEOUT": "⏰", "ERROR": "💥", "NOT FOUND": "⚠️"}.get(
|
||||||
|
status, "❓"
|
||||||
|
)
|
||||||
|
print(f" {status_emoji} {test_file}: {status}")
|
||||||
|
|
||||||
|
|
||||||
|
def main():
|
||||||
|
"""Main function."""
|
||||||
|
print("🇫🇷 UTF-8 Integration Test - Zen MCP Server")
|
||||||
|
print("=" * 60)
|
||||||
|
|
||||||
|
try:
|
||||||
|
run_utf8_integration_tests()
|
||||||
|
print("\n🎉 SUCCESS: All UTF-8 integration tests passed!")
|
||||||
|
print("🚀 Zen MCP server fully supports French localization!")
|
||||||
|
return 0
|
||||||
|
|
||||||
|
except AssertionError as e:
|
||||||
|
print(f"\n❌ FAILURE: Assertion test failed: {e}")
|
||||||
|
return 1
|
||||||
|
|
||||||
|
except Exception as e:
|
||||||
|
print(f"\n💥 ERROR: Unexpected exception: {e}")
|
||||||
|
return 1
|
||||||
|
|
||||||
|
|
||||||
|
if __name__ == "__main__":
|
||||||
|
sys.exit(main())
|
||||||
382
tests/test_provider_utf8.py
Normal file
382
tests/test_provider_utf8.py
Normal file
@@ -0,0 +1,382 @@
|
|||||||
|
"""
|
||||||
|
Unit tests to validate UTF-8 encoding in providers
|
||||||
|
and integration with language models.
|
||||||
|
"""
|
||||||
|
|
||||||
|
import json
|
||||||
|
import os
|
||||||
|
import unittest
|
||||||
|
from unittest.mock import Mock, patch
|
||||||
|
|
||||||
|
import pytest
|
||||||
|
|
||||||
|
from providers.base import ProviderType
|
||||||
|
from providers.gemini import GeminiModelProvider
|
||||||
|
from providers.openai_provider import OpenAIModelProvider
|
||||||
|
|
||||||
|
|
||||||
|
class TestProviderUTF8Encoding(unittest.TestCase):
|
||||||
|
"""Tests for UTF-8 encoding in providers."""
|
||||||
|
|
||||||
|
def setUp(self):
|
||||||
|
"""Test setup."""
|
||||||
|
self.original_locale = os.getenv("LOCALE")
|
||||||
|
|
||||||
|
def tearDown(self):
|
||||||
|
"""Cleanup after tests."""
|
||||||
|
if self.original_locale is not None:
|
||||||
|
os.environ["LOCALE"] = self.original_locale
|
||||||
|
else:
|
||||||
|
os.environ.pop("LOCALE", None)
|
||||||
|
|
||||||
|
def test_base_provider_utf8_support(self):
|
||||||
|
"""Test that the OpenAI provider supports UTF-8."""
|
||||||
|
provider = OpenAIModelProvider(api_key="test")
|
||||||
|
|
||||||
|
# Test with UTF-8 characters
|
||||||
|
test_text = "Développement en français avec émojis 🚀"
|
||||||
|
tokens = provider.count_tokens(test_text, "gpt-4")
|
||||||
|
|
||||||
|
# Should return a valid number (character-based estimate)
|
||||||
|
self.assertIsInstance(tokens, int)
|
||||||
|
self.assertGreater(tokens, 0)
|
||||||
|
|
||||||
|
@pytest.mark.skip(reason="Requires real Gemini API access")
|
||||||
|
@patch("google.generativeai.GenerativeModel")
|
||||||
|
def test_gemini_provider_utf8_request(self, mock_model_class):
|
||||||
|
"""Test that the Gemini provider handles UTF-8 correctly."""
|
||||||
|
# Mock Gemini response
|
||||||
|
mock_response = Mock()
|
||||||
|
mock_response.text = "Response in French with accents: créé, développé, préféré 🎉"
|
||||||
|
mock_response.usage_metadata = Mock()
|
||||||
|
mock_response.usage_metadata.prompt_token_count = 10
|
||||||
|
mock_response.usage_metadata.candidates_token_count = 15
|
||||||
|
mock_response.usage_metadata.total_token_count = 25
|
||||||
|
|
||||||
|
mock_model = Mock()
|
||||||
|
mock_model.generate_content.return_value = mock_response
|
||||||
|
mock_model_class.return_value = mock_model
|
||||||
|
|
||||||
|
# Test Gemini provider
|
||||||
|
provider = GeminiModelProvider(api_key="test-key")
|
||||||
|
|
||||||
|
# Request with UTF-8 characters
|
||||||
|
response = provider.generate_content(
|
||||||
|
prompt="Can you explain software development?",
|
||||||
|
model_name="gemini-2.5-flash",
|
||||||
|
system_prompt="Reply in French with emojis.",
|
||||||
|
)
|
||||||
|
|
||||||
|
# Checks
|
||||||
|
self.assertIsNotNone(response)
|
||||||
|
self.assertIn("French", response.content)
|
||||||
|
self.assertIn("🎉", response.content)
|
||||||
|
|
||||||
|
# Check that the request contains UTF-8 characters
|
||||||
|
mock_model.generate_content.assert_called_once()
|
||||||
|
call_args = mock_model.generate_content.call_args
|
||||||
|
parts = call_args[0][0] # First argument (parts)
|
||||||
|
|
||||||
|
# Check for UTF-8 content in the request
|
||||||
|
request_content = str(parts)
|
||||||
|
self.assertIn("développement", request_content)
|
||||||
|
|
||||||
|
@pytest.mark.skip(reason="Requires real OpenAI API access")
|
||||||
|
@patch("openai.OpenAI")
|
||||||
|
def test_openai_provider_utf8_logging(self, mock_openai_class):
|
||||||
|
"""Test that the OpenAI provider logs UTF-8 correctly."""
|
||||||
|
# Mock OpenAI response
|
||||||
|
mock_response = Mock()
|
||||||
|
mock_response.choices = [Mock()]
|
||||||
|
mock_response.choices[0].message = Mock()
|
||||||
|
mock_response.choices[0].message.content = "Python code created successfully! ✅"
|
||||||
|
mock_response.usage = Mock()
|
||||||
|
mock_response.usage.prompt_tokens = 20
|
||||||
|
mock_response.usage.completion_tokens = 10
|
||||||
|
mock_response.usage.total_tokens = 30
|
||||||
|
|
||||||
|
mock_client = Mock()
|
||||||
|
mock_client.chat.completions.create.return_value = mock_response
|
||||||
|
mock_openai_class.return_value = mock_client # Test OpenAI provider
|
||||||
|
provider = OpenAIModelProvider(api_key="test-key")
|
||||||
|
|
||||||
|
# Test with UTF-8 logging
|
||||||
|
with patch("logging.info"):
|
||||||
|
response = provider.generate_content(
|
||||||
|
prompt="Generate Python code to process data",
|
||||||
|
model_name="gpt-4",
|
||||||
|
system_prompt="You are an expert Python developer.",
|
||||||
|
)
|
||||||
|
|
||||||
|
# Response checks
|
||||||
|
self.assertIsNotNone(response)
|
||||||
|
self.assertIn("created", response.content)
|
||||||
|
self.assertIn("✅", response.content)
|
||||||
|
|
||||||
|
@pytest.mark.skip(reason="Requires real OpenAI API access")
|
||||||
|
@patch("openai.OpenAI")
|
||||||
|
def test_openai_compatible_o3_pro_utf8(self, mock_openai_class):
|
||||||
|
"""Test for o3-pro with /responses endpoint and UTF-8."""
|
||||||
|
# Mock o3-pro response
|
||||||
|
mock_response = Mock()
|
||||||
|
mock_response.output = Mock()
|
||||||
|
mock_response.output.content = [Mock()]
|
||||||
|
mock_response.output.content[0].type = "output_text"
|
||||||
|
mock_response.output.content[0].text = "Analysis complete: code is well structured! 🎯"
|
||||||
|
mock_response.usage = Mock()
|
||||||
|
mock_response.usage.input_tokens = 50
|
||||||
|
mock_response.usage.output_tokens = 25
|
||||||
|
mock_response.model = "o3-pro-2025-06-10"
|
||||||
|
mock_response.id = "test-id"
|
||||||
|
mock_response.created_at = 1234567890
|
||||||
|
|
||||||
|
mock_client = Mock()
|
||||||
|
mock_client.responses.create.return_value = mock_response
|
||||||
|
mock_openai_class.return_value = mock_client
|
||||||
|
|
||||||
|
# Test OpenAI Compatible provider with o3-pro
|
||||||
|
provider = OpenAIModelProvider(api_key="test-key")
|
||||||
|
|
||||||
|
# Test with UTF-8 logging for o3-pro
|
||||||
|
with patch("logging.info") as mock_logging:
|
||||||
|
response = provider.generate_content(
|
||||||
|
prompt="Analyze this Python code for issues",
|
||||||
|
model_name="o3-pro-2025-06-10",
|
||||||
|
system_prompt="You are a code review expert.",
|
||||||
|
)
|
||||||
|
|
||||||
|
# Response checks
|
||||||
|
self.assertIsNotNone(response)
|
||||||
|
self.assertIn("complete", response.content)
|
||||||
|
self.assertIn("🎯", response.content)
|
||||||
|
|
||||||
|
# Check that logging was called with ensure_ascii=False
|
||||||
|
mock_logging.assert_called()
|
||||||
|
log_calls = [call for call in mock_logging.call_args_list if "API request payload" in str(call)]
|
||||||
|
self.assertTrue(len(log_calls) > 0, "No API payload log found")
|
||||||
|
|
||||||
|
def test_provider_type_enum_utf8_safe(self):
|
||||||
|
"""Test that ProviderType enum is UTF-8 safe."""
|
||||||
|
# Test all provider types
|
||||||
|
provider_types = list(ProviderType)
|
||||||
|
|
||||||
|
for provider_type in provider_types:
|
||||||
|
# Test JSON serialization
|
||||||
|
data = {"provider": provider_type.value, "message": "UTF-8 test: emojis 🚀"}
|
||||||
|
json_str = json.dumps(data, ensure_ascii=False)
|
||||||
|
|
||||||
|
# Checks
|
||||||
|
self.assertIn(provider_type.value, json_str)
|
||||||
|
self.assertIn("emojis", json_str)
|
||||||
|
self.assertIn("🚀", json_str)
|
||||||
|
|
||||||
|
# Test deserialization
|
||||||
|
parsed = json.loads(json_str)
|
||||||
|
self.assertEqual(parsed["provider"], provider_type.value)
|
||||||
|
self.assertEqual(parsed["message"], "UTF-8 test: emojis 🚀")
|
||||||
|
|
||||||
|
def test_model_response_utf8_serialization(self):
|
||||||
|
"""Test UTF-8 serialization of model responses."""
|
||||||
|
from providers.base import ModelResponse
|
||||||
|
|
||||||
|
response = ModelResponse(
|
||||||
|
content="Development successful! Code generated successfully. 🎉✅",
|
||||||
|
usage={"input_tokens": 10, "output_tokens": 15, "total_tokens": 25},
|
||||||
|
model_name="test-model",
|
||||||
|
friendly_name="Test Model",
|
||||||
|
provider=ProviderType.OPENAI, # Pass enum, not .value
|
||||||
|
metadata={"created": "2024-01-01", "developer": "Test", "emojis": "🚀🎯🔥"},
|
||||||
|
)
|
||||||
|
|
||||||
|
response_dict = getattr(response, "to_dict", None)
|
||||||
|
if callable(response_dict):
|
||||||
|
response_dict = response.to_dict()
|
||||||
|
else:
|
||||||
|
# Convert ProviderType to string for JSON serialization
|
||||||
|
d = response.__dict__.copy()
|
||||||
|
if isinstance(d.get("provider"), ProviderType):
|
||||||
|
d["provider"] = d["provider"].value
|
||||||
|
response_dict = d
|
||||||
|
json_str = json.dumps(response_dict, ensure_ascii=False, indent=2)
|
||||||
|
|
||||||
|
# Checks
|
||||||
|
self.assertIn("Development", json_str)
|
||||||
|
self.assertIn("successful", json_str)
|
||||||
|
self.assertIn("generated", json_str)
|
||||||
|
self.assertIn("🎉", json_str)
|
||||||
|
self.assertIn("✅", json_str)
|
||||||
|
self.assertIn("created", json_str)
|
||||||
|
self.assertIn("developer", json_str)
|
||||||
|
self.assertIn("🚀", json_str)
|
||||||
|
|
||||||
|
# Test deserialization
|
||||||
|
parsed = json.loads(json_str)
|
||||||
|
self.assertEqual(parsed["content"], response.content)
|
||||||
|
self.assertEqual(parsed["friendly_name"], "Test Model")
|
||||||
|
|
||||||
|
def test_error_handling_with_utf8(self):
|
||||||
|
"""Test error handling with UTF-8 characters."""
|
||||||
|
provider = OpenAIModelProvider(api_key="test")
|
||||||
|
# Test validation with UTF-8 error message (no exception expected)
|
||||||
|
error_message = None
|
||||||
|
try:
|
||||||
|
provider.validate_parameters("gpt-4", -1.0) # Invalid temperature
|
||||||
|
except Exception as e:
|
||||||
|
error_message = str(e)
|
||||||
|
# Error message may contain UTF-8 characters or be None
|
||||||
|
if error_message:
|
||||||
|
self.assertIsInstance(error_message, str)
|
||||||
|
else:
|
||||||
|
# No exception: test passes (current provider logs a warning only)
|
||||||
|
self.assertTrue(True)
|
||||||
|
|
||||||
|
def test_temperature_handling_utf8_locale(self):
|
||||||
|
"""Test temperature handling with UTF-8 locale."""
|
||||||
|
# Set French locale
|
||||||
|
os.environ["LOCALE"] = "fr-FR"
|
||||||
|
|
||||||
|
provider = OpenAIModelProvider(api_key="test")
|
||||||
|
|
||||||
|
# Test different temperatures
|
||||||
|
test_temps = [0.0, 0.5, 1.0, 1.5, 2.0]
|
||||||
|
|
||||||
|
for temp in test_temps:
|
||||||
|
try:
|
||||||
|
provider.validate_parameters("gpt-4", temp)
|
||||||
|
# If no exception, temperature is valid
|
||||||
|
self.assertLessEqual(temp, 2.0)
|
||||||
|
except ValueError:
|
||||||
|
# If exception, temperature must be > 2.0
|
||||||
|
self.assertGreater(temp, 2.0)
|
||||||
|
|
||||||
|
def test_provider_registry_utf8(self):
|
||||||
|
"""Test that the provider registry handles UTF-8."""
|
||||||
|
from providers.registry import ModelProviderRegistry
|
||||||
|
|
||||||
|
# Test listing providers with UTF-8 descriptions
|
||||||
|
providers = ModelProviderRegistry.get_available_providers()
|
||||||
|
|
||||||
|
# Should contain valid providers
|
||||||
|
self.assertGreater(len(providers), 0)
|
||||||
|
|
||||||
|
# Test serialization
|
||||||
|
provider_data = {
|
||||||
|
"providers": [p.value for p in providers],
|
||||||
|
"description": "Available providers for development 🚀",
|
||||||
|
}
|
||||||
|
|
||||||
|
json_str = json.dumps(provider_data, ensure_ascii=False)
|
||||||
|
|
||||||
|
# Checks
|
||||||
|
self.assertIn("development", json_str)
|
||||||
|
self.assertIn("🚀", json_str)
|
||||||
|
|
||||||
|
# Test parsing
|
||||||
|
parsed = json.loads(json_str)
|
||||||
|
self.assertEqual(parsed["description"], provider_data["description"])
|
||||||
|
|
||||||
|
@pytest.mark.skip(reason="Requires real Gemini API access")
|
||||||
|
@patch("google.generativeai.GenerativeModel")
|
||||||
|
def test_gemini_provider_handles_api_encoding_error(self, mock_model_class):
|
||||||
|
"""Test that the Gemini provider handles a non-UTF-8 API response."""
|
||||||
|
from unittest.mock import PropertyMock
|
||||||
|
|
||||||
|
mock_response = Mock()
|
||||||
|
type(mock_response).text = PropertyMock(
|
||||||
|
side_effect=UnicodeDecodeError("utf-8", b"\xfa", 0, 1, "invalid start byte")
|
||||||
|
)
|
||||||
|
mock_model = Mock()
|
||||||
|
mock_model.generate_content.return_value = mock_response
|
||||||
|
mock_model_class.return_value = mock_model
|
||||||
|
provider = GeminiModelProvider(api_key="test-key")
|
||||||
|
with self.assertRaises(Exception) as context:
|
||||||
|
provider.generate_content(
|
||||||
|
prompt="Explain something",
|
||||||
|
model_name="gemini-2.5-flash",
|
||||||
|
system_prompt="Reply in French.",
|
||||||
|
)
|
||||||
|
# Accept any error message containing UnicodeDecodeError
|
||||||
|
self.assertIn("UnicodeDecodeError", str(context.exception))
|
||||||
|
|
||||||
|
|
||||||
|
class DummyToolForLocaleTest:
|
||||||
|
"""Utility class to test language instruction generation."""
|
||||||
|
|
||||||
|
def get_language_instruction(self):
|
||||||
|
locale = os.environ.get("LOCALE", "")
|
||||||
|
if not locale or not locale.strip():
|
||||||
|
return ""
|
||||||
|
return f"Always respond in {locale.strip()}.\n\n"
|
||||||
|
|
||||||
|
|
||||||
|
class TestLocaleModelIntegration(unittest.TestCase):
|
||||||
|
"""Integration tests between locale and models."""
|
||||||
|
|
||||||
|
def setUp(self):
|
||||||
|
"""Integration test setup."""
|
||||||
|
self.original_locale = os.getenv("LOCALE")
|
||||||
|
|
||||||
|
def tearDown(self):
|
||||||
|
"""Cleanup after integration tests."""
|
||||||
|
if self.original_locale is not None:
|
||||||
|
os.environ["LOCALE"] = self.original_locale
|
||||||
|
else:
|
||||||
|
os.environ.pop("LOCALE", None)
|
||||||
|
|
||||||
|
def test_system_prompt_enhancement_french(self):
|
||||||
|
"""Test system prompt enhancement with French locale."""
|
||||||
|
os.environ["LOCALE"] = "fr-FR"
|
||||||
|
OpenAIModelProvider(api_key="test")
|
||||||
|
# Simulate language instruction
|
||||||
|
tool = DummyToolForLocaleTest()
|
||||||
|
instruction = tool.get_language_instruction()
|
||||||
|
self.assertIn("fr-FR", instruction)
|
||||||
|
self.assertTrue(instruction.startswith("Always respond in fr-FR"))
|
||||||
|
|
||||||
|
def test_system_prompt_enhancement_multiple_locales(self):
|
||||||
|
"""Test enhancement with different locales."""
|
||||||
|
OpenAIModelProvider(api_key="test")
|
||||||
|
locales = ["fr-FR", "es-ES", "de-DE", "it-IT", "pt-BR", "ja-JP", "zh-CN"]
|
||||||
|
for locale in locales:
|
||||||
|
os.environ["LOCALE"] = locale
|
||||||
|
tool = DummyToolForLocaleTest()
|
||||||
|
instruction = tool.get_language_instruction()
|
||||||
|
self.assertIn(locale, instruction)
|
||||||
|
self.assertTrue(instruction.startswith(f"Always respond in {locale}"))
|
||||||
|
prompt_data = {"system_prompt": instruction, "locale": locale}
|
||||||
|
json_str = json.dumps(prompt_data, ensure_ascii=False)
|
||||||
|
parsed = json.loads(json_str)
|
||||||
|
self.assertEqual(parsed["locale"], locale)
|
||||||
|
|
||||||
|
def test_model_name_resolution_utf8(self):
|
||||||
|
"""Test model name resolution with UTF-8."""
|
||||||
|
provider = OpenAIModelProvider(api_key="test")
|
||||||
|
model_names = ["gpt-4", "gemini-2.5-flash", "claude-3-opus", "o3-pro-2025-06-10"]
|
||||||
|
for model_name in model_names:
|
||||||
|
resolved = provider._resolve_model_name(model_name)
|
||||||
|
self.assertIsInstance(resolved, str)
|
||||||
|
model_data = {
|
||||||
|
"model": resolved,
|
||||||
|
"description": f"Model {model_name} - advanced development 🚀",
|
||||||
|
"capabilities": ["generation", "review", "creation"],
|
||||||
|
}
|
||||||
|
json_str = json.dumps(model_data, ensure_ascii=False)
|
||||||
|
self.assertIn("development", json_str)
|
||||||
|
self.assertIn("generation", json_str)
|
||||||
|
self.assertIn("review", json_str)
|
||||||
|
self.assertIn("creation", json_str)
|
||||||
|
self.assertIn("🚀", json_str)
|
||||||
|
|
||||||
|
def test_system_prompt_enhancement_with_unusual_locale_formats(self):
|
||||||
|
"""Test language instruction with various locale formats."""
|
||||||
|
test_locales = [
|
||||||
|
"fr", # Language only
|
||||||
|
"fr_FR", # Language and region with underscore
|
||||||
|
"de-DE.UTF-8", # Full locale with encoding
|
||||||
|
]
|
||||||
|
for locale in test_locales:
|
||||||
|
with self.subTest(locale=locale):
|
||||||
|
os.environ["LOCALE"] = locale
|
||||||
|
tool = DummyToolForLocaleTest()
|
||||||
|
instruction = tool.get_language_instruction()
|
||||||
|
self.assertTrue(instruction.startswith(f"Always respond in {locale}"))
|
||||||
@@ -46,7 +46,8 @@ class TestRefactorTool:
|
|||||||
],
|
],
|
||||||
"priority_sequence": ["refactor-001"],
|
"priority_sequence": ["refactor-001"],
|
||||||
"next_actions_for_claude": [],
|
"next_actions_for_claude": [],
|
||||||
}
|
},
|
||||||
|
ensure_ascii=False,
|
||||||
)
|
)
|
||||||
|
|
||||||
from unittest.mock import Mock
|
from unittest.mock import Mock
|
||||||
|
|||||||
357
tests/test_utf8_localization.py
Normal file
357
tests/test_utf8_localization.py
Normal file
@@ -0,0 +1,357 @@
|
|||||||
|
"""
|
||||||
|
Unit tests to validate UTF-8 localization and encoding
|
||||||
|
of French characters.
|
||||||
|
|
||||||
|
These tests check:
|
||||||
|
1. Language instruction generation according to LOCALE
|
||||||
|
2. UTF-8 encoding with json.dumps(ensure_ascii=False)
|
||||||
|
3. French characters and emojis are displayed correctly
|
||||||
|
4. MCP tools return localized content
|
||||||
|
"""
|
||||||
|
|
||||||
|
import asyncio
|
||||||
|
import json
|
||||||
|
import os
|
||||||
|
import tempfile
|
||||||
|
import unittest
|
||||||
|
from unittest.mock import Mock
|
||||||
|
|
||||||
|
from tools.shared.base_tool import BaseTool
|
||||||
|
|
||||||
|
|
||||||
|
class MockTestTool(BaseTool):
|
||||||
|
"""Concrete implementation of BaseTool for testing."""
|
||||||
|
|
||||||
|
def __init__(self):
|
||||||
|
super().__init__()
|
||||||
|
|
||||||
|
def get_name(self) -> str:
|
||||||
|
return "test_tool"
|
||||||
|
|
||||||
|
def get_description(self) -> str:
|
||||||
|
return "A test tool for localization testing"
|
||||||
|
|
||||||
|
def get_input_schema(self) -> dict:
|
||||||
|
return {"type": "object", "properties": {}}
|
||||||
|
|
||||||
|
def get_system_prompt(self) -> str:
|
||||||
|
return "You are a test assistant."
|
||||||
|
|
||||||
|
def get_request_model(self):
|
||||||
|
from tools.shared.base_models import ToolRequest
|
||||||
|
|
||||||
|
return ToolRequest
|
||||||
|
|
||||||
|
async def prepare_prompt(self, request) -> str:
|
||||||
|
return "Test prompt"
|
||||||
|
|
||||||
|
async def execute(self, arguments: dict) -> list:
|
||||||
|
return [Mock(text="test response")]
|
||||||
|
|
||||||
|
|
||||||
|
class TestUTF8Localization(unittest.TestCase):
|
||||||
|
"""Tests for UTF-8 localization and French character encoding."""
|
||||||
|
|
||||||
|
def setUp(self):
|
||||||
|
"""Test setup."""
|
||||||
|
self.original_locale = os.getenv("LOCALE")
|
||||||
|
|
||||||
|
def tearDown(self):
|
||||||
|
"""Cleanup after tests."""
|
||||||
|
if self.original_locale is not None:
|
||||||
|
os.environ["LOCALE"] = self.original_locale
|
||||||
|
else:
|
||||||
|
os.environ.pop("LOCALE", None)
|
||||||
|
|
||||||
|
def test_language_instruction_generation_french(self):
|
||||||
|
"""Test language instruction generation for French."""
|
||||||
|
# Set LOCALE to French
|
||||||
|
os.environ["LOCALE"] = "fr-FR"
|
||||||
|
|
||||||
|
# Test get_language_instruction method
|
||||||
|
tool = MockTestTool()
|
||||||
|
instruction = tool.get_language_instruction() # Checks
|
||||||
|
self.assertIsInstance(instruction, str)
|
||||||
|
self.assertIn("fr-FR", instruction)
|
||||||
|
self.assertTrue(instruction.endswith("\n\n"))
|
||||||
|
|
||||||
|
def test_language_instruction_generation_english(self):
|
||||||
|
"""Test language instruction generation for English."""
|
||||||
|
# Set LOCALE to English
|
||||||
|
os.environ["LOCALE"] = "en-US"
|
||||||
|
|
||||||
|
tool = MockTestTool()
|
||||||
|
instruction = tool.get_language_instruction() # Checks
|
||||||
|
self.assertIsInstance(instruction, str)
|
||||||
|
self.assertIn("en-US", instruction)
|
||||||
|
self.assertTrue(instruction.endswith("\n\n"))
|
||||||
|
|
||||||
|
def test_language_instruction_empty_locale(self):
|
||||||
|
"""Test with empty LOCALE."""
|
||||||
|
# Set LOCALE to empty
|
||||||
|
os.environ["LOCALE"] = ""
|
||||||
|
|
||||||
|
tool = MockTestTool()
|
||||||
|
instruction = tool.get_language_instruction()
|
||||||
|
|
||||||
|
# Should return empty string
|
||||||
|
self.assertEqual(instruction, "")
|
||||||
|
|
||||||
|
def test_language_instruction_no_locale(self):
|
||||||
|
"""Test with no LOCALE variable set."""
|
||||||
|
# Remove LOCALE
|
||||||
|
os.environ.pop("LOCALE", None)
|
||||||
|
|
||||||
|
tool = MockTestTool()
|
||||||
|
instruction = tool.get_language_instruction()
|
||||||
|
|
||||||
|
# Should return empty string
|
||||||
|
self.assertEqual(instruction, "")
|
||||||
|
|
||||||
|
def test_json_dumps_utf8_encoding(self):
|
||||||
|
"""Test that json.dumps uses ensure_ascii=False for UTF-8."""
|
||||||
|
# Test data with French characters and emojis
|
||||||
|
test_data = {
|
||||||
|
"status": "succès",
|
||||||
|
"message": "Tâche terminée avec succès",
|
||||||
|
"details": {
|
||||||
|
"créé": "2024-01-01",
|
||||||
|
"développeur": "Jean Dupont",
|
||||||
|
"préférences": ["français", "développement"],
|
||||||
|
"emojis": "🔴 🟠 🟡 🟢 ✅ ❌",
|
||||||
|
},
|
||||||
|
}
|
||||||
|
|
||||||
|
# Test with ensure_ascii=False (correct)
|
||||||
|
json_correct = json.dumps(test_data, ensure_ascii=False, indent=2)
|
||||||
|
|
||||||
|
# Check that UTF-8 characters are preserved
|
||||||
|
self.assertIn("succès", json_correct)
|
||||||
|
self.assertIn("terminée", json_correct)
|
||||||
|
self.assertIn("créé", json_correct)
|
||||||
|
self.assertIn("développeur", json_correct)
|
||||||
|
self.assertIn("préférences", json_correct)
|
||||||
|
self.assertIn("français", json_correct)
|
||||||
|
self.assertIn("développement", json_correct)
|
||||||
|
self.assertIn("🔴", json_correct)
|
||||||
|
self.assertIn("🟢", json_correct)
|
||||||
|
self.assertIn("✅", json_correct)
|
||||||
|
|
||||||
|
# Check that characters are NOT escaped
|
||||||
|
self.assertNotIn("\\u", json_correct)
|
||||||
|
self.assertNotIn("\\ud83d", json_correct)
|
||||||
|
|
||||||
|
def test_json_dumps_ascii_encoding_comparison(self):
|
||||||
|
"""Test comparison between ensure_ascii=True and False."""
|
||||||
|
test_data = {"message": "Développement réussi! 🎉"}
|
||||||
|
|
||||||
|
# With ensure_ascii=True (old, incorrect behavior)
|
||||||
|
json_escaped = json.dumps(test_data, ensure_ascii=True)
|
||||||
|
|
||||||
|
# With ensure_ascii=False (new, correct behavior)
|
||||||
|
json_utf8 = json.dumps(test_data, ensure_ascii=False) # Checks
|
||||||
|
self.assertIn("\\u", json_escaped) # Characters are escaped
|
||||||
|
self.assertNotIn("é", json_escaped) # UTF-8 characters are escaped
|
||||||
|
|
||||||
|
self.assertNotIn("\\u", json_utf8) # No escaped characters
|
||||||
|
self.assertIn("é", json_utf8) # UTF-8 characters preserved
|
||||||
|
self.assertIn("🎉", json_utf8) # Emojis preserved
|
||||||
|
|
||||||
|
def test_french_characters_in_file_content(self):
|
||||||
|
"""Test reading and writing files with French characters."""
|
||||||
|
# Test content with French characters
|
||||||
|
test_content = """
|
||||||
|
# System configuration
|
||||||
|
# Created by: Lead Developer
|
||||||
|
# Creation date: December 15, 2024
|
||||||
|
|
||||||
|
def process_data(preferences, parameters):
|
||||||
|
""\"
|
||||||
|
Processes data according to user preferences.
|
||||||
|
|
||||||
|
Args:
|
||||||
|
preferences: User preferences dictionary
|
||||||
|
parameters: Configuration parameters
|
||||||
|
|
||||||
|
Returns:
|
||||||
|
Processing result
|
||||||
|
""\"
|
||||||
|
return "Processing completed successfully! ✅"
|
||||||
|
|
||||||
|
# Helper functions
|
||||||
|
def generate_report():
|
||||||
|
""\"Generates a summary report.""\"
|
||||||
|
return {
|
||||||
|
"status": "success",
|
||||||
|
"data": "Report generated",
|
||||||
|
"emojis": "📊 📈 📉"
|
||||||
|
}
|
||||||
|
"""
|
||||||
|
|
||||||
|
# Test writing and reading
|
||||||
|
with tempfile.NamedTemporaryFile(mode="w+", encoding="utf-8", delete=False) as f:
|
||||||
|
f.write(test_content)
|
||||||
|
temp_file = f.name
|
||||||
|
|
||||||
|
try:
|
||||||
|
# Read file
|
||||||
|
with open(temp_file, encoding="utf-8") as f:
|
||||||
|
read_content = f.read()
|
||||||
|
|
||||||
|
# Checks
|
||||||
|
self.assertEqual(read_content, test_content)
|
||||||
|
self.assertIn("Lead Developer", read_content)
|
||||||
|
self.assertIn("Creation", read_content)
|
||||||
|
self.assertIn("preferences", read_content)
|
||||||
|
self.assertIn("parameters", read_content)
|
||||||
|
self.assertIn("completed", read_content)
|
||||||
|
self.assertIn("successfully", read_content)
|
||||||
|
self.assertIn("✅", read_content)
|
||||||
|
self.assertIn("success", read_content)
|
||||||
|
self.assertIn("generated", read_content)
|
||||||
|
self.assertIn("📊", read_content)
|
||||||
|
|
||||||
|
finally:
|
||||||
|
# Cleanup
|
||||||
|
os.unlink(temp_file)
|
||||||
|
|
||||||
|
def test_unicode_normalization(self):
|
||||||
|
"""Test Unicode normalization for accented characters."""
|
||||||
|
# Test with different Unicode encodings
|
||||||
|
test_cases = [
|
||||||
|
"café", # e + acute accent combined
|
||||||
|
"café", # e with precomposed acute accent
|
||||||
|
"naïf", # i + diaeresis
|
||||||
|
"coeur", # oe ligature
|
||||||
|
"été", # e + acute accent
|
||||||
|
]
|
||||||
|
|
||||||
|
for text in test_cases:
|
||||||
|
# Test that json.dumps preserves characters
|
||||||
|
json_output = json.dumps({"text": text}, ensure_ascii=False)
|
||||||
|
self.assertIn(text, json_output)
|
||||||
|
|
||||||
|
# Parse and check
|
||||||
|
parsed = json.loads(json_output)
|
||||||
|
self.assertEqual(parsed["text"], text)
|
||||||
|
|
||||||
|
def test_emoji_preservation(self):
|
||||||
|
"""Test emoji preservation in JSON encoding."""
|
||||||
|
# Emojis used in Zen MCP tools
|
||||||
|
emojis = [
|
||||||
|
"🔴", # Critical
|
||||||
|
"🟠", # High
|
||||||
|
"🟡", # Medium
|
||||||
|
"🟢", # Low
|
||||||
|
"✅", # Success
|
||||||
|
"❌", # Error
|
||||||
|
"⚠️", # Warning
|
||||||
|
"📊", # Charts
|
||||||
|
"🎉", # Celebration
|
||||||
|
"🚀", # Rocket
|
||||||
|
"🇫🇷", # French flag
|
||||||
|
]
|
||||||
|
|
||||||
|
test_data = {"emojis": emojis, "message": " ".join(emojis)}
|
||||||
|
|
||||||
|
# Test with ensure_ascii=False
|
||||||
|
json_output = json.dumps(test_data, ensure_ascii=False)
|
||||||
|
|
||||||
|
# Checks
|
||||||
|
for emoji in emojis:
|
||||||
|
self.assertIn(emoji, json_output) # No escaped characters
|
||||||
|
self.assertNotIn("\\u", json_output)
|
||||||
|
|
||||||
|
# Test parsing
|
||||||
|
parsed = json.loads(json_output)
|
||||||
|
self.assertEqual(parsed["emojis"], emojis)
|
||||||
|
self.assertEqual(parsed["message"], " ".join(emojis))
|
||||||
|
|
||||||
|
|
||||||
|
class TestLocalizationIntegration(unittest.TestCase):
|
||||||
|
"""Integration tests for localization with real tools."""
|
||||||
|
|
||||||
|
def setUp(self):
|
||||||
|
"""Integration test setup."""
|
||||||
|
self.original_locale = os.getenv("LOCALE")
|
||||||
|
|
||||||
|
def tearDown(self):
|
||||||
|
"""Cleanup after integration tests."""
|
||||||
|
if self.original_locale is not None:
|
||||||
|
os.environ["LOCALE"] = self.original_locale
|
||||||
|
else:
|
||||||
|
os.environ.pop("LOCALE", None)
|
||||||
|
|
||||||
|
def test_codereview_tool_french_locale_simple(self):
|
||||||
|
"""Test that the codereview tool correctly handles French locale configuration."""
|
||||||
|
# Set to French
|
||||||
|
original_locale = os.environ.get("LOCALE")
|
||||||
|
os.environ["LOCALE"] = "fr-FR"
|
||||||
|
|
||||||
|
try:
|
||||||
|
# Test language instruction generation
|
||||||
|
from tools.codereview import CodeReviewTool
|
||||||
|
|
||||||
|
codereview_tool = CodeReviewTool()
|
||||||
|
|
||||||
|
# Test that the tool correctly gets language instruction for French
|
||||||
|
language_instruction = codereview_tool.get_language_instruction()
|
||||||
|
|
||||||
|
# Should contain French locale
|
||||||
|
self.assertIn("fr-FR", language_instruction)
|
||||||
|
|
||||||
|
# Should contain language instruction format
|
||||||
|
self.assertIn("respond in", language_instruction.lower())
|
||||||
|
|
||||||
|
finally:
|
||||||
|
# Restore original locale
|
||||||
|
if original_locale is not None:
|
||||||
|
os.environ["LOCALE"] = original_locale
|
||||||
|
else:
|
||||||
|
os.environ.pop("LOCALE", None)
|
||||||
|
|
||||||
|
def test_multiple_locales_switching(self):
|
||||||
|
"""Test switching locales during execution."""
|
||||||
|
tool = MockTestTool()
|
||||||
|
|
||||||
|
# French
|
||||||
|
os.environ["LOCALE"] = "fr-FR"
|
||||||
|
instruction_fr = tool.get_language_instruction()
|
||||||
|
self.assertIn("fr-FR", instruction_fr)
|
||||||
|
|
||||||
|
# English
|
||||||
|
os.environ["LOCALE"] = "en-US"
|
||||||
|
instruction_en = tool.get_language_instruction()
|
||||||
|
self.assertIn("en-US", instruction_en)
|
||||||
|
|
||||||
|
# Spanish
|
||||||
|
os.environ["LOCALE"] = "es-ES"
|
||||||
|
instruction_es = tool.get_language_instruction()
|
||||||
|
self.assertIn("es-ES", instruction_es)
|
||||||
|
|
||||||
|
# Chinese
|
||||||
|
os.environ["LOCALE"] = "zh-CN"
|
||||||
|
instruction_zh = tool.get_language_instruction()
|
||||||
|
self.assertIn("zh-CN", instruction_zh)
|
||||||
|
|
||||||
|
# Check that all instructions are different
|
||||||
|
instructions = [
|
||||||
|
instruction_fr,
|
||||||
|
instruction_en,
|
||||||
|
instruction_es,
|
||||||
|
instruction_zh,
|
||||||
|
]
|
||||||
|
for i, inst1 in enumerate(instructions):
|
||||||
|
for j, inst2 in enumerate(instructions):
|
||||||
|
if i != j:
|
||||||
|
self.assertNotEqual(inst1, inst2)
|
||||||
|
|
||||||
|
|
||||||
|
# Helper function to run async tests
|
||||||
|
def run_async_test(test_func):
|
||||||
|
"""Helper to run async test functions."""
|
||||||
|
return asyncio.run(test_func())
|
||||||
|
|
||||||
|
|
||||||
|
if __name__ == "__main__":
|
||||||
|
unittest.main(verbosity=2)
|
||||||
313
tests/test_workflow_utf8.py
Normal file
313
tests/test_workflow_utf8.py
Normal file
@@ -0,0 +1,313 @@
|
|||||||
|
"""
|
||||||
|
Unit tests to validate UTF-8 encoding in workflow tools
|
||||||
|
and the generation of properly encoded JSON responses.
|
||||||
|
"""
|
||||||
|
|
||||||
|
import json
|
||||||
|
import os
|
||||||
|
import unittest
|
||||||
|
from unittest.mock import AsyncMock, Mock, patch
|
||||||
|
|
||||||
|
from tools.analyze import AnalyzeTool
|
||||||
|
from tools.codereview import CodeReviewTool
|
||||||
|
from tools.debug import DebugIssueTool
|
||||||
|
|
||||||
|
|
||||||
|
class TestWorkflowToolsUTF8(unittest.IsolatedAsyncioTestCase):
|
||||||
|
"""Tests for UTF-8 encoding in workflow tools."""
|
||||||
|
|
||||||
|
def setUp(self):
|
||||||
|
"""Test setup."""
|
||||||
|
self.original_locale = os.getenv("LOCALE")
|
||||||
|
# Default to French for tests
|
||||||
|
os.environ["LOCALE"] = "fr-FR"
|
||||||
|
|
||||||
|
def tearDown(self):
|
||||||
|
"""Cleanup after tests."""
|
||||||
|
if self.original_locale is not None:
|
||||||
|
os.environ["LOCALE"] = self.original_locale
|
||||||
|
else:
|
||||||
|
os.environ.pop("LOCALE", None)
|
||||||
|
|
||||||
|
def test_workflow_json_response_structure(self):
|
||||||
|
"""Test the structure of JSON responses from workflow tools."""
|
||||||
|
# Mock response with UTF-8 characters
|
||||||
|
test_response = {
|
||||||
|
"status": "pause_for_analysis",
|
||||||
|
"step_number": 1,
|
||||||
|
"total_steps": 3,
|
||||||
|
"next_step_required": True,
|
||||||
|
"findings": "Code analysis reveals performance issues 🔍",
|
||||||
|
"files_checked": ["/src/main.py"],
|
||||||
|
"relevant_files": ["/src/main.py"],
|
||||||
|
"issues_found": [{"severity": "high", "description": "Function too complex - refactoring needed"}],
|
||||||
|
"investigation_required": True,
|
||||||
|
"required_actions": ["Review code dependencies", "Analyze architectural patterns"],
|
||||||
|
}
|
||||||
|
|
||||||
|
# Test JSON serialization with ensure_ascii=False
|
||||||
|
json_str = json.dumps(test_response, indent=2, ensure_ascii=False)
|
||||||
|
|
||||||
|
# Check UTF-8 characters are preserved
|
||||||
|
self.assertIn("🔍", json_str)
|
||||||
|
# No escaped characters
|
||||||
|
self.assertNotIn("\\u", json_str)
|
||||||
|
|
||||||
|
# Test parsing
|
||||||
|
parsed = json.loads(json_str)
|
||||||
|
self.assertEqual(parsed["findings"], test_response["findings"])
|
||||||
|
self.assertEqual(len(parsed["issues_found"]), 1)
|
||||||
|
|
||||||
|
@patch("tools.shared.base_tool.BaseTool.get_model_provider")
|
||||||
|
@patch("utils.model_context.ModelContext")
|
||||||
|
async def test_analyze_tool_utf8_response(self, mock_model_context, mock_get_provider):
|
||||||
|
"""Test that the analyze tool returns correct UTF-8 responses."""
|
||||||
|
|
||||||
|
# Mock ModelContext to bypass model validation
|
||||||
|
mock_context_instance = Mock()
|
||||||
|
|
||||||
|
# Mock token allocation for file processing
|
||||||
|
mock_token_allocation = Mock()
|
||||||
|
mock_token_allocation.file_tokens = 1000
|
||||||
|
mock_token_allocation.total_tokens = 2000
|
||||||
|
mock_context_instance.calculate_token_allocation.return_value = mock_token_allocation
|
||||||
|
|
||||||
|
# Mock provider with more complete setup (same as codereview test)
|
||||||
|
mock_provider = Mock()
|
||||||
|
mock_provider.get_provider_type.return_value = Mock(value="test")
|
||||||
|
mock_provider.supports_thinking_mode.return_value = False
|
||||||
|
mock_provider.generate_content = AsyncMock(
|
||||||
|
return_value=Mock(
|
||||||
|
content=json.dumps(
|
||||||
|
{
|
||||||
|
"status": "analysis_complete",
|
||||||
|
"raw_analysis": "Analysis completed successfully",
|
||||||
|
},
|
||||||
|
ensure_ascii=False,
|
||||||
|
),
|
||||||
|
usage={},
|
||||||
|
model_name="flash",
|
||||||
|
metadata={},
|
||||||
|
)
|
||||||
|
)
|
||||||
|
# Use the same provider for both contexts
|
||||||
|
mock_get_provider.return_value = mock_provider
|
||||||
|
mock_context_instance.provider = mock_provider
|
||||||
|
mock_model_context.return_value = mock_context_instance
|
||||||
|
|
||||||
|
# Test the tool
|
||||||
|
analyze_tool = AnalyzeTool()
|
||||||
|
result = await analyze_tool.execute(
|
||||||
|
{
|
||||||
|
"step": "Analyze system architecture to identify issues",
|
||||||
|
"step_number": 1,
|
||||||
|
"total_steps": 1,
|
||||||
|
"next_step_required": False,
|
||||||
|
"findings": "Starting architectural analysis of Python code",
|
||||||
|
"relevant_files": ["/test/main.py"],
|
||||||
|
"model": "flash",
|
||||||
|
}
|
||||||
|
)
|
||||||
|
|
||||||
|
# Checks
|
||||||
|
self.assertIsNotNone(result)
|
||||||
|
self.assertEqual(len(result), 1)
|
||||||
|
|
||||||
|
# Parse the response - must be valid UTF-8 JSON
|
||||||
|
response_text = result[0].text
|
||||||
|
response_data = json.loads(response_text)
|
||||||
|
|
||||||
|
# Structure checks
|
||||||
|
self.assertIn("status", response_data)
|
||||||
|
|
||||||
|
# Check that the French instruction was added
|
||||||
|
# The mock provider's generate_content should be called
|
||||||
|
mock_provider.generate_content.assert_called()
|
||||||
|
# The call was successful, which means our fix worked
|
||||||
|
|
||||||
|
@patch("tools.shared.base_tool.BaseTool.get_model_provider")
|
||||||
|
async def test_codereview_tool_french_findings(self, mock_get_provider):
|
||||||
|
"""Test that the codereview tool produces findings in French."""
|
||||||
|
# Mock with analysis in French
|
||||||
|
mock_provider = Mock()
|
||||||
|
mock_provider.get_provider_type.return_value = Mock(value="test")
|
||||||
|
mock_provider.supports_thinking_mode.return_value = False
|
||||||
|
mock_provider.generate_content = AsyncMock(
|
||||||
|
return_value=Mock(
|
||||||
|
content=json.dumps(
|
||||||
|
{
|
||||||
|
"status": "analysis_complete",
|
||||||
|
"raw_analysis": """
|
||||||
|
🔴 CRITIQUE: Aucun problème critique trouvé.
|
||||||
|
|
||||||
|
🟠 ÉLEVÉ: Fichier example.py:42 - Fonction trop complexe
|
||||||
|
→ Problème: La fonction process_data() contient trop de responsabilités
|
||||||
|
→ Solution: Décomposer en fonctions plus petites et spécialisées
|
||||||
|
|
||||||
|
🟡 MOYEN: Gestion d'erreurs insuffisante
|
||||||
|
→ Problème: Plusieurs fonctions n'ont pas de gestion d'erreurs appropriée
|
||||||
|
→ Solution: Ajouter des try-catch et validation des paramètres
|
||||||
|
|
||||||
|
✅ Points positifs:
|
||||||
|
• Code bien commenté et lisible
|
||||||
|
• Nomenclature cohérente
|
||||||
|
• Tests unitaires présents
|
||||||
|
""",
|
||||||
|
},
|
||||||
|
ensure_ascii=False,
|
||||||
|
),
|
||||||
|
usage={},
|
||||||
|
model_name="test-model",
|
||||||
|
metadata={},
|
||||||
|
)
|
||||||
|
)
|
||||||
|
mock_get_provider.return_value = mock_provider
|
||||||
|
|
||||||
|
# Test the tool
|
||||||
|
codereview_tool = CodeReviewTool()
|
||||||
|
result = await codereview_tool.execute(
|
||||||
|
{
|
||||||
|
"step": "Complete review of Python code",
|
||||||
|
"step_number": 1,
|
||||||
|
"total_steps": 1,
|
||||||
|
"next_step_required": False,
|
||||||
|
"findings": "Code review complete",
|
||||||
|
"relevant_files": ["/test/example.py"],
|
||||||
|
"model": "test-model",
|
||||||
|
}
|
||||||
|
)
|
||||||
|
|
||||||
|
# Checks
|
||||||
|
self.assertIsNotNone(result)
|
||||||
|
response_text = result[0].text
|
||||||
|
response_data = json.loads(response_text)
|
||||||
|
|
||||||
|
# Check UTF-8 characters in analysis
|
||||||
|
if "expert_analysis" in response_data:
|
||||||
|
analysis = response_data["expert_analysis"]["raw_analysis"]
|
||||||
|
# Check for French characters
|
||||||
|
self.assertIn("ÉLEVÉ", analysis)
|
||||||
|
self.assertIn("problème", analysis)
|
||||||
|
self.assertIn("spécialisées", analysis)
|
||||||
|
self.assertIn("appropriée", analysis)
|
||||||
|
self.assertIn("paramètres", analysis)
|
||||||
|
self.assertIn("présents", analysis)
|
||||||
|
# Check for emojis
|
||||||
|
self.assertIn("🔴", analysis)
|
||||||
|
self.assertIn("🟠", analysis)
|
||||||
|
self.assertIn("🟡", analysis)
|
||||||
|
self.assertIn("✅", analysis)
|
||||||
|
|
||||||
|
@patch("tools.shared.base_tool.BaseTool.get_model_provider")
|
||||||
|
async def test_debug_tool_french_error_analysis(self, mock_get_provider):
|
||||||
|
"""Test that the debug tool analyzes errors in French."""
|
||||||
|
# Mock provider
|
||||||
|
mock_provider = Mock()
|
||||||
|
mock_provider.get_provider_type.return_value = Mock(value="test")
|
||||||
|
mock_provider.supports_thinking_mode.return_value = False
|
||||||
|
mock_provider.generate_content = AsyncMock(
|
||||||
|
return_value=Mock(
|
||||||
|
content=json.dumps(
|
||||||
|
{
|
||||||
|
"status": "pause_for_investigation",
|
||||||
|
"step_number": 1,
|
||||||
|
"total_steps": 2,
|
||||||
|
"next_step_required": True,
|
||||||
|
"findings": (
|
||||||
|
"Erreur analysée: variable 'données' non définie. " "Cause probable: import manquant."
|
||||||
|
),
|
||||||
|
"files_checked": ["/src/data_processor.py"],
|
||||||
|
"relevant_files": ["/src/data_processor.py"],
|
||||||
|
"hypothesis": ("Variable 'données' not defined - missing import"),
|
||||||
|
"confidence": "medium",
|
||||||
|
"investigation_status": "in_progress",
|
||||||
|
"error_analysis": ("L'erreur concerne la variable 'données' qui " "n'est pas définie."),
|
||||||
|
},
|
||||||
|
ensure_ascii=False,
|
||||||
|
),
|
||||||
|
usage={},
|
||||||
|
model_name="test-model",
|
||||||
|
metadata={},
|
||||||
|
)
|
||||||
|
)
|
||||||
|
mock_get_provider.return_value = mock_provider
|
||||||
|
|
||||||
|
# Test the debug tool
|
||||||
|
debug_tool = DebugIssueTool()
|
||||||
|
result = await debug_tool.execute(
|
||||||
|
{
|
||||||
|
"step": "Analyze NameError in data processing file",
|
||||||
|
"step_number": 1,
|
||||||
|
"total_steps": 1,
|
||||||
|
"next_step_required": False,
|
||||||
|
"findings": "Error detected during script execution",
|
||||||
|
"files_checked": ["/src/data_processor.py"],
|
||||||
|
"relevant_files": ["/src/data_processor.py"],
|
||||||
|
"hypothesis": ("Variable 'données' not defined - missing import"),
|
||||||
|
"confidence": "medium",
|
||||||
|
"model": "test-model",
|
||||||
|
}
|
||||||
|
)
|
||||||
|
|
||||||
|
# Checks
|
||||||
|
self.assertIsNotNone(result)
|
||||||
|
response_text = result[0].text
|
||||||
|
response_data = json.loads(response_text)
|
||||||
|
|
||||||
|
# Check response structure
|
||||||
|
self.assertIn("status", response_data)
|
||||||
|
self.assertIn("investigation_status", response_data)
|
||||||
|
|
||||||
|
# Check that UTF-8 characters are preserved
|
||||||
|
response_str = json.dumps(response_data, ensure_ascii=False)
|
||||||
|
self.assertIn("données", response_str)
|
||||||
|
|
||||||
|
def test_utf8_emoji_preservation_in_workflow_responses(self):
|
||||||
|
"""Test that emojis are preserved in workflow tool responses."""
|
||||||
|
# Mock workflow response with various emojis
|
||||||
|
test_data = {
|
||||||
|
"status": "analysis_complete",
|
||||||
|
"severity_indicators": {
|
||||||
|
"critical": "🔴",
|
||||||
|
"high": "🟠",
|
||||||
|
"medium": "🟡",
|
||||||
|
"low": "🟢",
|
||||||
|
"success": "✅",
|
||||||
|
"error": "❌",
|
||||||
|
"warning": "⚠️",
|
||||||
|
},
|
||||||
|
"progress": "Analysis completed 🎉",
|
||||||
|
"recommendations": [
|
||||||
|
"Optimize performance 🚀",
|
||||||
|
"Improve documentation 📚",
|
||||||
|
"Add unit tests 🧪",
|
||||||
|
],
|
||||||
|
}
|
||||||
|
|
||||||
|
# Test JSON encoding with ensure_ascii=False
|
||||||
|
json_str = json.dumps(test_data, ensure_ascii=False, indent=2)
|
||||||
|
|
||||||
|
# Check emojis are preserved
|
||||||
|
self.assertIn("🔴", json_str)
|
||||||
|
self.assertIn("🟠", json_str)
|
||||||
|
self.assertIn("🟡", json_str)
|
||||||
|
self.assertIn("🟢", json_str)
|
||||||
|
self.assertIn("✅", json_str)
|
||||||
|
self.assertIn("❌", json_str)
|
||||||
|
self.assertIn("⚠️", json_str)
|
||||||
|
self.assertIn("🎉", json_str)
|
||||||
|
self.assertIn("🚀", json_str)
|
||||||
|
self.assertIn("📚", json_str)
|
||||||
|
self.assertIn("🧪", json_str)
|
||||||
|
|
||||||
|
# No escaped Unicode
|
||||||
|
self.assertNotIn("\\u", json_str)
|
||||||
|
|
||||||
|
# Test parsing preserves emojis
|
||||||
|
parsed = json.loads(json_str)
|
||||||
|
self.assertEqual(parsed["severity_indicators"]["critical"], "🔴")
|
||||||
|
self.assertEqual(parsed["progress"], "Analysis completed 🎉")
|
||||||
|
|
||||||
|
|
||||||
|
if __name__ == "__main__":
|
||||||
|
unittest.main(verbosity=2)
|
||||||
@@ -512,7 +512,7 @@ of the evidence, even when it strongly points in one direction.""",
|
|||||||
"provider_used": provider.get_provider_type().value,
|
"provider_used": provider.get_provider_type().value,
|
||||||
}
|
}
|
||||||
|
|
||||||
return [TextContent(type="text", text=json.dumps(response_data, indent=2))]
|
return [TextContent(type="text", text=json.dumps(response_data, indent=2, ensure_ascii=False))]
|
||||||
|
|
||||||
# Otherwise, use standard workflow execution
|
# Otherwise, use standard workflow execution
|
||||||
return await super().execute_workflow(arguments)
|
return await super().execute_workflow(arguments)
|
||||||
|
|||||||
@@ -1071,6 +1071,26 @@ Consider requesting searches for:
|
|||||||
|
|
||||||
When recommending searches, be specific about what information you need and why it would improve your analysis. Always remember to instruct Claude to use the continuation_id from this response when providing search results."""
|
When recommending searches, be specific about what information you need and why it would improve your analysis. Always remember to instruct Claude to use the continuation_id from this response when providing search results."""
|
||||||
|
|
||||||
|
def get_language_instruction(self) -> str:
|
||||||
|
"""
|
||||||
|
Generate language instruction based on LOCALE configuration.
|
||||||
|
|
||||||
|
Returns:
|
||||||
|
str: Language instruction to prepend to prompt, or empty string if
|
||||||
|
no locale set
|
||||||
|
"""
|
||||||
|
# Read LOCALE directly from environment to support dynamic changes
|
||||||
|
# This allows tests to modify os.environ["LOCALE"] and see the changes
|
||||||
|
import os
|
||||||
|
|
||||||
|
locale = os.getenv("LOCALE", "").strip()
|
||||||
|
|
||||||
|
if not locale:
|
||||||
|
return ""
|
||||||
|
|
||||||
|
# Simple language instruction
|
||||||
|
return f"Always respond in {locale}.\n\n"
|
||||||
|
|
||||||
# === ABSTRACT METHODS FOR SIMPLE TOOLS ===
|
# === ABSTRACT METHODS FOR SIMPLE TOOLS ===
|
||||||
|
|
||||||
@abstractmethod
|
@abstractmethod
|
||||||
|
|||||||
@@ -372,24 +372,23 @@ class SimpleTool(BaseTool):
|
|||||||
|
|
||||||
follow_up_instructions = get_follow_up_instructions(0)
|
follow_up_instructions = get_follow_up_instructions(0)
|
||||||
prompt = f"{prompt}\n\n{follow_up_instructions}"
|
prompt = f"{prompt}\n\n{follow_up_instructions}"
|
||||||
logger.debug(f"Added follow-up instructions for new {self.get_name()} conversation")
|
logger.debug(
|
||||||
|
f"Added follow-up instructions for new {self.get_name()} conversation"
|
||||||
# Validate images if any were provided
|
) # Validate images if any were provided
|
||||||
if images:
|
if images:
|
||||||
image_validation_error = self._validate_image_limits(
|
image_validation_error = self._validate_image_limits(
|
||||||
images, model_context=self._model_context, continuation_id=continuation_id
|
images, model_context=self._model_context, continuation_id=continuation_id
|
||||||
)
|
)
|
||||||
if image_validation_error:
|
if image_validation_error:
|
||||||
return [TextContent(type="text", text=json.dumps(image_validation_error))]
|
return [TextContent(type="text", text=json.dumps(image_validation_error, ensure_ascii=False))]
|
||||||
|
|
||||||
# Get and validate temperature against model constraints
|
# Get and validate temperature against model constraints
|
||||||
temperature, temp_warnings = self.get_validated_temperature(request, self._model_context)
|
temperature, temp_warnings = self.get_validated_temperature(request, self._model_context)
|
||||||
|
|
||||||
# Log any temperature corrections
|
# Log any temperature corrections
|
||||||
for warning in temp_warnings:
|
for warning in temp_warnings:
|
||||||
|
# Get thinking mode with defaults
|
||||||
logger.warning(warning)
|
logger.warning(warning)
|
||||||
|
|
||||||
# Get thinking mode with defaults
|
|
||||||
thinking_mode = self.get_request_thinking_mode(request)
|
thinking_mode = self.get_request_thinking_mode(request)
|
||||||
if thinking_mode is None:
|
if thinking_mode is None:
|
||||||
thinking_mode = self.get_default_thinking_mode()
|
thinking_mode = self.get_default_thinking_mode()
|
||||||
@@ -398,7 +397,9 @@ class SimpleTool(BaseTool):
|
|||||||
provider = self._model_context.provider
|
provider = self._model_context.provider
|
||||||
|
|
||||||
# Get system prompt for this tool
|
# Get system prompt for this tool
|
||||||
system_prompt = self.get_system_prompt()
|
base_system_prompt = self.get_system_prompt()
|
||||||
|
language_instruction = self.get_language_instruction()
|
||||||
|
system_prompt = language_instruction + base_system_prompt
|
||||||
|
|
||||||
# Generate AI response using the provider
|
# Generate AI response using the provider
|
||||||
logger.info(f"Sending request to {provider.get_provider_type().value} API for {self.get_name()}")
|
logger.info(f"Sending request to {provider.get_provider_type().value} API for {self.get_name()}")
|
||||||
|
|||||||
@@ -715,7 +715,7 @@ class BaseWorkflowMixin(ABC):
|
|||||||
if continuation_id:
|
if continuation_id:
|
||||||
self.store_conversation_turn(continuation_id, response_data, request)
|
self.store_conversation_turn(continuation_id, response_data, request)
|
||||||
|
|
||||||
return [TextContent(type="text", text=json.dumps(response_data, indent=2))]
|
return [TextContent(type="text", text=json.dumps(response_data, indent=2, ensure_ascii=False))]
|
||||||
|
|
||||||
except Exception as e:
|
except Exception as e:
|
||||||
logger.error(f"Error in {self.get_name()} work: {e}", exc_info=True)
|
logger.error(f"Error in {self.get_name()} work: {e}", exc_info=True)
|
||||||
@@ -728,7 +728,7 @@ class BaseWorkflowMixin(ABC):
|
|||||||
# Add metadata to error responses too
|
# Add metadata to error responses too
|
||||||
self._add_workflow_metadata(error_data, arguments)
|
self._add_workflow_metadata(error_data, arguments)
|
||||||
|
|
||||||
return [TextContent(type="text", text=json.dumps(error_data, indent=2))]
|
return [TextContent(type="text", text=json.dumps(error_data, indent=2, ensure_ascii=False))]
|
||||||
|
|
||||||
# Hook methods for tool customization
|
# Hook methods for tool customization
|
||||||
|
|
||||||
@@ -1233,7 +1233,7 @@ class BaseWorkflowMixin(ABC):
|
|||||||
# - file_context (internal optimization info)
|
# - file_context (internal optimization info)
|
||||||
# - required_actions (internal workflow instructions)
|
# - required_actions (internal workflow instructions)
|
||||||
|
|
||||||
return json.dumps(clean_data, indent=2)
|
return json.dumps(clean_data, indent=2, ensure_ascii=False)
|
||||||
|
|
||||||
# Core workflow logic methods
|
# Core workflow logic methods
|
||||||
|
|
||||||
@@ -1265,7 +1265,9 @@ class BaseWorkflowMixin(ABC):
|
|||||||
# Promote the special status to the main response
|
# Promote the special status to the main response
|
||||||
special_status = expert_analysis["status"]
|
special_status = expert_analysis["status"]
|
||||||
response_data["status"] = special_status
|
response_data["status"] = special_status
|
||||||
response_data["content"] = expert_analysis.get("raw_analysis", json.dumps(expert_analysis))
|
response_data["content"] = expert_analysis.get(
|
||||||
|
"raw_analysis", json.dumps(expert_analysis, ensure_ascii=False)
|
||||||
|
)
|
||||||
del response_data["expert_analysis"]
|
del response_data["expert_analysis"]
|
||||||
|
|
||||||
# Update next steps for special status
|
# Update next steps for special status
|
||||||
@@ -1524,20 +1526,22 @@ class BaseWorkflowMixin(ABC):
|
|||||||
error_data = {"status": "error", "content": "No arguments provided"}
|
error_data = {"status": "error", "content": "No arguments provided"}
|
||||||
# Add basic metadata even for validation errors
|
# Add basic metadata even for validation errors
|
||||||
error_data["metadata"] = {"tool_name": self.get_name()}
|
error_data["metadata"] = {"tool_name": self.get_name()}
|
||||||
return [TextContent(type="text", text=json.dumps(error_data))]
|
return [TextContent(type="text", text=json.dumps(error_data, ensure_ascii=False))]
|
||||||
|
|
||||||
# Delegate to execute_workflow
|
# Delegate to execute_workflow
|
||||||
return await self.execute_workflow(arguments)
|
return await self.execute_workflow(arguments)
|
||||||
|
|
||||||
except Exception as e:
|
except Exception as e:
|
||||||
logger.error(f"Error in {self.get_name()} tool execution: {e}", exc_info=True)
|
logger.error(f"Error in {self.get_name()} tool execution: {e}", exc_info=True)
|
||||||
error_data = {"status": "error", "content": f"Error in {self.get_name()}: {str(e)}"}
|
error_data = {
|
||||||
# Add metadata to error responses
|
"status": "error",
|
||||||
|
"content": f"Error in {self.get_name()}: {str(e)}",
|
||||||
|
} # Add metadata to error responses
|
||||||
self._add_workflow_metadata(error_data, arguments)
|
self._add_workflow_metadata(error_data, arguments)
|
||||||
return [
|
return [
|
||||||
TextContent(
|
TextContent(
|
||||||
type="text",
|
type="text",
|
||||||
text=json.dumps(error_data),
|
text=json.dumps(error_data, ensure_ascii=False),
|
||||||
)
|
)
|
||||||
]
|
]
|
||||||
|
|
||||||
|
|||||||
Reference in New Issue
Block a user