Address code review: use constant array for proxy env vars and clean empty env

Co-authored-by: simon-ami <102378134+simon-ami@users.noreply.github.com>
This commit is contained in:
copilot-swe-agent[bot]
2026-01-11 11:56:01 +00:00
parent 8eba68e47a
commit cd594f6e82

View File

@@ -445,16 +445,27 @@ export function mountWebUI(app, dirname, accountManager) {
try { try {
const claudeConfig = await readClaudeConfig(); const claudeConfig = await readClaudeConfig();
// Proxy-related environment variables to remove when restoring defaults
const PROXY_ENV_VARS = [
'ANTHROPIC_BASE_URL',
'ANTHROPIC_AUTH_TOKEN',
'ANTHROPIC_MODEL',
'CLAUDE_CODE_SUBAGENT_MODEL',
'ANTHROPIC_DEFAULT_OPUS_MODEL',
'ANTHROPIC_DEFAULT_SONNET_MODEL',
'ANTHROPIC_DEFAULT_HAIKU_MODEL',
'ENABLE_EXPERIMENTAL_MCP_CLI'
];
// Remove proxy-related environment variables to restore defaults // Remove proxy-related environment variables to restore defaults
if (claudeConfig.env) { if (claudeConfig.env) {
delete claudeConfig.env.ANTHROPIC_BASE_URL; for (const key of PROXY_ENV_VARS) {
delete claudeConfig.env.ANTHROPIC_AUTH_TOKEN; delete claudeConfig.env[key];
delete claudeConfig.env.ANTHROPIC_MODEL; }
delete claudeConfig.env.CLAUDE_CODE_SUBAGENT_MODEL; // Remove env entirely if empty to truly restore defaults
delete claudeConfig.env.ANTHROPIC_DEFAULT_OPUS_MODEL; if (Object.keys(claudeConfig.env).length === 0) {
delete claudeConfig.env.ANTHROPIC_DEFAULT_SONNET_MODEL; delete claudeConfig.env;
delete claudeConfig.env.ANTHROPIC_DEFAULT_HAIKU_MODEL; }
delete claudeConfig.env.ENABLE_EXPERIMENTAL_MCP_CLI;
} }
// Use replaceClaudeConfig to completely overwrite the config (not merge) // Use replaceClaudeConfig to completely overwrite the config (not merge)