Improve cross-model thinking handling and add gemini-3-flash fallback

- Add gemini-3-flash to MODEL_FALLBACK_MAP for completeness
- Add hasGeminiHistory() to detect Gemini→Claude cross-model switch
- Trigger recovery for Claude only when Gemini history detected
- Remove unnecessary thinking block filtering for Claude-only conversations
- Add comments explaining '.' placeholder usage
- Remove unused filterUnsignedThinkingFromMessages function

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
This commit is contained in:
Badri Narayanan S
2026-01-04 00:11:14 +05:30
parent 53f8d7f6cc
commit 141558dd62
3 changed files with 40 additions and 15 deletions

View File

@@ -146,11 +146,12 @@ export const OAUTH_REDIRECT_URI = `http://localhost:${OAUTH_CONFIG.callbackPort}
// Model fallback mapping - maps primary model to fallback when quota exhausted // Model fallback mapping - maps primary model to fallback when quota exhausted
export const MODEL_FALLBACK_MAP = { export const MODEL_FALLBACK_MAP = {
'gemini-3-pro-high': 'claude-sonnet-4-5-thinking', 'gemini-3-pro-high': 'claude-opus-4-5-thinking',
'gemini-3-pro-low': 'claude-sonnet-4-5', 'gemini-3-pro-low': 'claude-sonnet-4-5',
'gemini-3-flash': 'claude-sonnet-4-5-thinking',
'claude-opus-4-5-thinking': 'gemini-3-pro-high', 'claude-opus-4-5-thinking': 'gemini-3-pro-high',
'claude-sonnet-4-5-thinking': 'gemini-3-pro-high', 'claude-sonnet-4-5-thinking': 'gemini-3-flash',
'claude-sonnet-4-5': 'gemini-3-pro-low' 'claude-sonnet-4-5': 'gemini-3-flash'
}; };
export default { export default {

View File

@@ -15,6 +15,7 @@ import {
removeTrailingThinkingBlocks, removeTrailingThinkingBlocks,
reorderAssistantContent, reorderAssistantContent,
filterUnsignedThinkingBlocks, filterUnsignedThinkingBlocks,
hasGeminiHistory,
needsThinkingRecovery, needsThinkingRecovery,
closeToolLoopForThinking closeToolLoopForThinking
} from './thinking-utils.js'; } from './thinking-utils.js';
@@ -77,15 +78,20 @@ export function convertAnthropicToGoogle(anthropicRequest) {
} }
} }
// Apply thinking recovery for thinking models when needed // Apply thinking recovery for Gemini thinking models when needed
// - Gemini: needs recovery for tool loops/interrupted tools (stripped thinking) // Gemini needs recovery for tool loops/interrupted tools (stripped thinking)
// - Claude: needs recovery ONLY when cross-model (incompatible Gemini signatures will be dropped)
let processedMessages = messages; let processedMessages = messages;
const targetFamily = isClaudeModel ? 'claude' : isGeminiModel ? 'gemini' : null;
if (isThinking && targetFamily && needsThinkingRecovery(messages)) { if (isGeminiModel && isThinking && needsThinkingRecovery(messages)) {
logger.debug(`[RequestConverter] Applying thinking recovery for ${targetFamily}`); logger.debug('[RequestConverter] Applying thinking recovery for Gemini');
processedMessages = closeToolLoopForThinking(messages, targetFamily); processedMessages = closeToolLoopForThinking(messages, 'gemini');
}
// For Claude: apply recovery only for cross-model (Gemini→Claude) switch
// Detected by checking if history has Gemini-style tool_use with thoughtSignature
if (isClaudeModel && isThinking && hasGeminiHistory(messages) && needsThinkingRecovery(messages)) {
logger.debug('[RequestConverter] Applying thinking recovery for Claude (cross-model from Gemini)');
processedMessages = closeToolLoopForThinking(messages, 'claude');
} }
// Convert messages to contents, then filter unsigned thinking blocks // Convert messages to contents, then filter unsigned thinking blocks
@@ -108,6 +114,8 @@ export function convertAnthropicToGoogle(anthropicRequest) {
// SAFETY: Google API requires at least one part per content message // SAFETY: Google API requires at least one part per content message
// This happens when all thinking blocks are filtered out (unsigned) // This happens when all thinking blocks are filtered out (unsigned)
if (parts.length === 0) { if (parts.length === 0) {
// Use '.' instead of '' because claude models reject empty text parts.
// A single period is invisible in practice but satisfies the API requirement.
logger.warn('[RequestConverter] WARNING: Empty parts array after filtering, adding placeholder'); logger.warn('[RequestConverter] WARNING: Empty parts array after filtering, adding placeholder');
parts.push({ text: '.' }); parts.push({ text: '.' });
} }

View File

@@ -27,6 +27,21 @@ export function hasValidSignature(part) {
return typeof signature === 'string' && signature.length >= MIN_SIGNATURE_LENGTH; return typeof signature === 'string' && signature.length >= MIN_SIGNATURE_LENGTH;
} }
/**
* Check if conversation history contains Gemini-style messages.
* Gemini puts thoughtSignature on tool_use blocks, Claude puts signature on thinking blocks.
* @param {Array<Object>} messages - Array of messages
* @returns {boolean} True if any tool_use has thoughtSignature (Gemini pattern)
*/
export function hasGeminiHistory(messages) {
return messages.some(msg =>
Array.isArray(msg.content) &&
msg.content.some(block =>
block.type === 'tool_use' && block.thoughtSignature !== undefined
)
);
}
/** /**
* Sanitize a thinking part by keeping only allowed fields * Sanitize a thinking part by keeping only allowed fields
*/ */
@@ -434,14 +449,14 @@ function stripInvalidThinkingBlocks(messages, targetFamily = null) {
return false; return false;
} }
// Check family compatibility if targetFamily is provided // Check family compatibility only for Gemini targets
if (targetFamily) { // Claude can validate its own signatures, so we don't drop for Claude
if (targetFamily === 'gemini') {
const signature = block.thought === true ? block.thoughtSignature : block.signature; const signature = block.thought === true ? block.thoughtSignature : block.signature;
const signatureFamily = getCachedSignatureFamily(signature); const signatureFamily = getCachedSignatureFamily(signature);
// Strict validation: If we don't know the family (cache miss) or it doesn't match, // For Gemini: drop unknown or mismatched signatures
// we drop it. We don't assume validity for unknown signatures. if (!signatureFamily || signatureFamily !== targetFamily) {
if (signatureFamily !== targetFamily) {
strippedCount++; strippedCount++;
return false; return false;
} }
@@ -450,6 +465,7 @@ function stripInvalidThinkingBlocks(messages, targetFamily = null) {
return true; return true;
}); });
// Use '.' instead of '' because claude models reject empty text parts
if (msg.content) { if (msg.content) {
return { ...msg, content: filtered.length > 0 ? filtered : [{ type: 'text', text: '.' }] }; return { ...msg, content: filtered.length > 0 ? filtered : [{ type: 'text', text: '.' }] };
} else if (msg.parts) { } else if (msg.parts) {